From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAA46C32771 for ; Fri, 19 Aug 2022 15:24:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M8QXH4PXzz3dwm for ; Sat, 20 Aug 2022 01:24:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Q5keVqP0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=geoff@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Q5keVqP0; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M8QWT5Yklz3bYG for ; Sat, 20 Aug 2022 01:23:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=tb0EOcj/cP/ZuwLYxWcP43h5C3E6flLzxmX2a1wEjWs=; b=Q5keVqP0r9w7d9aLb3DgGx7Ytw 5UBgPFlT3NnvngRx82tAQhpQmKXgysZ3PFvV1gDsRBGB2a+s9IBjZsvS8fMKv2tanvmNoj619SOil CouctGihln6nnZfiOtGIhl0rEVKsFC5VmZPyoGAOSEvzjTsJQmCrVxAQCu7viSwktTwFbZJjB13K/ BcUKVoyTWq1DpTsP6/Z6pCwJ3fsu1RcTSossiXXHE1a4KGo+omusLuRZBROtlerIoeYSREp9fkQa/ SgjARaqLNZhtzbBl3rBx6AyCS3M9juEwPlF3jm+xR7WmYgPPvV7xoMw39jsnlEKo1TuyEjw8xJXyl PZQYEHzg==; Received: from [2600:1702:3c30:6ca0:77cd:43b1:3d69:dd7b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3ow-00BHmH-Fb; Fri, 19 Aug 2022 15:22:02 +0000 Message-ID: <66f8a3a6-22d5-8a1b-e011-c50de8e19e6c@infradead.org> Date: Fri, 19 Aug 2022 08:21:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] block: move from strlcpy with unused retval to strscpy Content-Language: en-US To: Wolfram Sang , linux-kernel@vger.kernel.org References: <20220818205958.6552-1-wsa+renesas@sang-engineering.com> From: Geoff Levand In-Reply-To: <20220818205958.6552-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Minchan Kim , linuxppc-dev@lists.ozlabs.org, Philipp Reisner , Jim Paris , linux-block@vger.kernel.org, =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= , Nicholas Piggin , Lars Ellenberg , Sergey Senozhatsky , Nitin Gupta , drbd-dev@lists.linbit.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 8/18/22 13:59, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- ... > diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c > index e1d080f680ed..c76e0148eada 100644 > --- a/drivers/block/ps3vram.c > +++ b/drivers/block/ps3vram.c > @@ -745,7 +745,7 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev) > gendisk->flags |= GENHD_FL_NO_PART; > gendisk->fops = &ps3vram_fops; > gendisk->private_data = dev; > - strlcpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name)); > + strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name)); > set_capacity(gendisk, priv->size >> 9); > blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS); > blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE); Seems OK for ps3vram. Acked-by: Geoff Levand