linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <kumar.gala@freescale.com>
To: "Dan Malek" <dan@embeddededge.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: RFC: cpm2_devices.c
Date: Thu, 16 Jun 2005 10:33:23 -0500	[thread overview]
Message-ID: <678305db5ee1488bb48a26a4a89c121a@freescale.com> (raw)
In-Reply-To: <0fc7d3f2fe1266cdd0beaf44a71bc27c@embeddededge.com>

Dan,

If I understand you correctly this is not any different than how we 
handle the TSEC (gianfar) on 85xx.  The platform device structure just 
gives us physical address (start & end) and IRQs and we use a structure 
in the driver that maps to the start address.

- kumar

> Having just converted an different SoC part from using offsets to data
> structures, I have to say that tables/defines of offsets are more of a
> mess
> than a data structure.  We don't have to define the whole of the IMMAP,
> but
> using the data structures for the individual device spaces is quite
> effective.
> The advantage of using the data structure is it also conveys the data
> type
> size, adding a level error checking.  I also dislike io accessor
> functions/macros,
> especially on these processor specific devices.
>
>
> Thanks.
>
> 	-- Dan

  reply	other threads:[~2005-06-16 15:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-14 18:18 RFC: cpm2_devices.c Allen Curtis
2005-06-15  3:35 ` Kumar Gala
2005-06-15  3:57   ` Allen Curtis
2005-06-15  4:13     ` Kumar Gala
2005-06-15  4:41       ` Allen Curtis
2005-06-15 14:24         ` Jason McMullan
2005-06-15 15:06           ` Kumar Gala
2005-06-15 17:48             ` Allen Curtis
2005-06-15 18:05               ` Vitaly Bordug
2005-06-15 14:29         ` Kumar Gala
2005-06-15 14:30         ` Kumar Gala
2005-06-16 15:12       ` Dan Malek
2005-06-16 15:33         ` Kumar Gala [this message]
2005-06-16 15:42           ` Allen Curtis
2005-06-16 15:53             ` Kumar Gala
2005-06-16 16:39               ` Allen Curtis
2005-06-16 19:33           ` Dan Malek
2005-06-15  7:55   ` Vitaly Bordug
2005-06-15 14:25     ` Kumar Gala
2005-06-15 14:33       ` Jason McMullan
2005-06-15 15:01         ` Kumar Gala
2005-06-15 15:31       ` Vitaly Bordug
2005-06-15 15:41         ` Kumar Gala
2005-06-15 16:07           ` Vitaly Bordug
2005-06-16  6:42           ` Pantelis Antoniou
2005-06-16  9:33             ` Wolfgang Denk
2005-06-16 15:02             ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=678305db5ee1488bb48a26a4a89c121a@freescale.com \
    --to=kumar.gala@freescale.com \
    --cc=dan@embeddededge.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).