From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60268EA4FBA for ; Mon, 23 Feb 2026 13:14:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fKLtM3xSrz2yDk; Tue, 24 Feb 2026 00:14:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771852491; cv=none; b=V3uraajeyIgvo97pvCgbHINagcJA8t0W5QR2t7D3QpOAAJFGhVFeZ+OVUtm1ZsK1vtKHjpQpjBeCeC421+YP5NU38FMB1wU4BsSp3/erHaK+1vJ+mh/RWiq1cgSj4xhimn5WyuK8BO3A7nzJAi1kMQj2F1QEloQg4H2CyBbNxUFXIs3STT34JGpbrpe36sJs3QqI5JphrbkEUM9WOh9cdBPAN9nhDP+zSrkfTWsoq8OSRQnbPLtDXpLDZYoomtiveV/dIbuudcsIbZnpFryiZGPo0rEPm2+W7c7wFGSYTzf2hGXpW1pJBkd70zapWvUjtpbm3REAdBX2hK1gF7ur8Q== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1771852491; c=relaxed/relaxed; bh=zYhRLoiK0VLHYOzUwBccbAM03Ht3O7rDyk48fwSLsM4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=bNkHrXjFDqu2cmtkv2tpEKf/pdaVjWK1M1P6RUQ/XO+/h9xbhcH76VmpShNzr8JcpTuwXX2Xt7no2HzL6V2LcfMd3fZIS5qkXzy2/Asu5mfxvzvm2GELZEAUlOeshzWAsVvR68c+goVu4sk/2gUXCjOSD294Kvdhzptpa+Ba1c4JIVGcwDrtI1UARgY4MEgvbaFMci2qUblM/Di7XltuX6kEK5Q7NnPHIQFEwAuKmp2RZaKJAdJcdY5x0Amph1UwRte/EWhywdWUfH3AuOdRQWUBlWvrdTPWeOXaEIwwGeeRul3yjgaG8lavefc9niCftfes1RHeMLVxnCzVrqRnUA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=VhVTfmRZ; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=sshegde@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=VhVTfmRZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=sshegde@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fKLtL2Jdrz2xN8 for ; Tue, 24 Feb 2026 00:14:49 +1100 (AEDT) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N1F85K2962734; Mon, 23 Feb 2026 13:14:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=zYhRLo iK0VLHYOzUwBccbAM03Ht3O7rDyk48fwSLsM4=; b=VhVTfmRZlcgUlS2H4zoNjO cIoftXjrnJVO+eqs4xb2LmUjPaQvMLgx3ARvMEmIwP/wzgaXegXa4SMfxebr4Jl6 rOrZqqcQQVdXVymS4xyFEhlh7kHdBUqOgX+u0fj6nYjsUiXPIPVeFEI78dC0r0og gBu6wELB17+OmxixdGAA+Np2BXE4pyxsunqdDVWs/UBpEt1i+S5lWwcNwrRFbWA3 Sqbwh3UB5HI+rcOfsm98h8jwSnrrCYtuKxzjE31EPy9hMQOYJy4FynC5EQqFa4b4 VE1MZ+O/BlCHbXVsqMxxfDDFtylqNuDNvU+Hu5Hq2CvooDNEb1G1Jb9Q1nVL1oPA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4cf24g703j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 13:14:03 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61NBfIQK003836; Mon, 23 Feb 2026 13:14:02 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4cfs8jmn9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Feb 2026 13:14:02 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61NDE1Qp49545712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Feb 2026 13:14:01 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F358B20040; Mon, 23 Feb 2026 13:14:00 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D9172004B; Mon, 23 Feb 2026 13:13:44 +0000 (GMT) Received: from [9.124.223.211] (unknown [9.124.223.211]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 23 Feb 2026 13:13:44 +0000 (GMT) Message-ID: <68149255-7398-466b-9d97-7f0124fda25b@linux.ibm.com> Date: Mon, 23 Feb 2026 18:43:42 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] powerpc/xive: simplify xive_spapr_debug_show() To: Yury Norov , linuxppc-dev@lists.ozlabs.org References: <20260219181407.290201-1-ynorov@nvidia.com> <20260219181407.290201-2-ynorov@nvidia.com> From: Shrikanth Hegde Content-Language: en-US Cc: linux-kernel@vger.kernel.org, "Christophe Leroy (CS GROUP)" , "David S. Miller" , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" , Alexander Shishkin , Andrew Lunn , Andrew Morton , Antoine Tenart , Christian Brauner , Daniel Lezcano , Eric Dumazet , Geetha sowjanya , Ingo Molnar , Jakub Kicinski , James Clark , Jerin Jacob , Linu Cherian , Lukasz Luba , Madhavan Srinivasan , Michael Ellerman , Mike Leach , Moritz Fischer , Nicholas Piggin , Paolo Abeni , Rasmus Villemoes , Simon Horman , Stanislav Fomichev , Subbaraya Sundeep , Sunil Goutham , Suzuki K Poulose , Tom Rix , Xu Yilun , Yajun Deng , Yury Norov , Zhang Rui , hariprasad , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-fpga@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20260219181407.290201-2-ynorov@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=TNRIilla c=1 sm=1 tr=0 ts=699c529c cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=Ikd4Dj_1AAAA:8 a=VnNF1IyMAAAA:8 a=RRjIJgXTCtlgTdhHy9AA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: zk86Bjz-ydPJYTzK12ycUFUxtnx4SsWL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDExMyBTYWx0ZWRfXzUksRw9myqEz UixBWMUBZhLNgjnHiRif4qEj6UTL9WGyZkn27yUtF6CWFb9SYDOGa8ybNIYcoScAvxJAjZvhNeN crWv2GETS4bYnOXhGA0j9jBzFducGZUXccIKv+/lCjc59Y7xepUBptqzpDWEqkQeTWTMZOLtDAe JKMVrv5POWEa1ALIBmUFCCdNJAw5xb1J1rgrHt8KhPKHVdM2T59DOL7PmtHzE85KWEwjN5v4NGp KwqvUOH7ymRE+6kwdl+0y/KIhzwB4XbaesJX00qvqjBCniVexgjmFtm0aMlvo60ZeN66AO42SpO fZ+eus7mxmnk4gnXvoIwI7BShUWgz1g/JfCJNmaSyECFzmtlwps2RusoWi6ud1HQYaHQSf5ROEo rm2QmGaze6ialIdxLy6AR7amIsOcyElw9lE3OHW750fh185sPBRKByN+/ioJoQpV2aiqznoRRJa UDMaxIW562x9oJGezoA== X-Proofpoint-ORIG-GUID: Hf_7wRhC8iujCJ7VvfJzpi5rfR7wKIcE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602230113 On 2/19/26 11:43 PM, Yury Norov wrote: > The function creates temporary buffer to convert xibm->bitmap to a > human-readable list before passing it to seq_printf. Drop it and print > the list in seq_printf() directly with the "%*pbl" specifier. > > Signed-off-by: Yury Norov > --- > arch/powerpc/sysdev/xive/spapr.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 5aedbe3e8e6a..f818299579b1 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -667,17 +667,9 @@ static void xive_spapr_sync_source(u32 hw_irq) > static int xive_spapr_debug_show(struct seq_file *m, void *private) > { > struct xive_irq_bitmap *xibm; > - char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > > - if (!buf) > - return -ENOMEM; > - > - list_for_each_entry(xibm, &xive_irq_bitmaps, list) { > - memset(buf, 0, PAGE_SIZE); > - bitmap_print_to_pagebuf(true, buf, xibm->bitmap, xibm->count); > - seq_printf(m, "bitmap #%d: %s", xibm->count, buf); > - } > - kfree(buf); > + list_for_each_entry(xibm, &xive_irq_bitmaps, list) > + seq_printf(m, "bitmap #%d: %*pbl\n", xibm->count, xibm->count, xibm->bitmap); > > return 0; > } Looks good to me. Reviewed-by: Shrikanth Hegde