From: Chengyang Fan <cy.fan@huawei.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: joe@perches.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: remove unneeded semicolons
Date: Sat, 30 Jan 2021 09:31:37 +0800 [thread overview]
Message-ID: <686a4fd1-cbe8-4c60-ea5c-e64b00f5b608@huawei.com> (raw)
In-Reply-To: <87v9bgc6al.fsf@mpe.ellerman.id.au>
Although they are harmless, I think we should keep the consistency of
kernel coding style.
Thanks
On 2021/1/29 19:48, Michael Ellerman wrote:
> Chengyang Fan <cy.fan@huawei.com> writes:
>> Remove superfluous semicolons after function definitions.
> Is there a good reason why?
>
> I realise they're superfluous, but they're also harmless as far as I'm
> aware.
>
> cheers
>
>> arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +-
>> arch/powerpc/include/asm/book3s/64/mmu.h | 2 +-
>> arch/powerpc/include/asm/book3s/64/tlbflush-radix.h | 2 +-
>> arch/powerpc/include/asm/book3s/64/tlbflush.h | 2 +-
>> arch/powerpc/include/asm/firmware.h | 2 +-
>> arch/powerpc/include/asm/kvm_ppc.h | 6 +++---
>> arch/powerpc/include/asm/paca.h | 6 +++---
>> arch/powerpc/include/asm/rtas.h | 2 +-
>> arch/powerpc/include/asm/setup.h | 6 +++---
>> arch/powerpc/include/asm/simple_spinlock.h | 4 ++--
>> arch/powerpc/include/asm/smp.h | 2 +-
>> arch/powerpc/include/asm/xmon.h | 4 ++--
>> arch/powerpc/kernel/prom.c | 2 +-
>> arch/powerpc/kernel/setup.h | 12 ++++++------
>> arch/powerpc/platforms/powernv/subcore.h | 2 +-
>> arch/powerpc/platforms/pseries/pseries.h | 2 +-
>> 16 files changed, 29 insertions(+), 29 deletions(-)
> .
next prev parent reply other threads:[~2021-01-30 1:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 9:53 [PATCH] powerpc: remove unneeded semicolons Chengyang Fan
2021-01-29 11:48 ` Michael Ellerman
2021-01-30 1:31 ` Chengyang Fan [this message]
2021-02-10 12:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=686a4fd1-cbe8-4c60-ea5c-e64b00f5b608@huawei.com \
--to=cy.fan@huawei.com \
--cc=joe@perches.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox