linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Becky Bruce <Becky.Bruce@freescale.com>
To: Assaf Hoffman <hoffman@marvell.com>
Cc: linuxppc-embedded@ozlabs.org, Rita Shtern <rita@marvell.com>,
	Ronen Shitrit <rshitrit@marvell.com>
Subject: Re: Setting I&D cache enable in the same mtspr instruction
Date: Wed, 31 May 2006 18:06:43 -0500	[thread overview]
Message-ID: <687F6669-B58A-404A-9AC2-EDC34107F0EC@freescale.com> (raw)
In-Reply-To: <B9FFC3F97441D04093A504CEA31B7C41A62B2F@msilexch01.marvell.com>


I think we need to hold off on this particular patch for a few days.   
I took a look at the manual section you're referencing here, and sure  
enough, it says that you shouldn't set both bits in the same mtspr  
instruction.  The manual says this in more than one place, in fact.   
However, that seemed a little bit odd to me, so I talked with a few  
of the hardware designers for the 745x family.  They assure me that  
the manual statement is false.  The normal code that sets ICE/ICFI/ 
DCE/DCFI all on one mtspr should be fully functional on this  
processor family.  I'm still working on confirming this and getting  
some history on *why* the manual says that, but for now I'd say it's  
a pretty good bet that the manual is in error.  I will let you know  
if I find out this is not the case.

You are correct, though, in that an isync is needed prior to the  
write of HID0[ICE]. It's probably missing because it's not listed in  
the synchronization table in chapter 2 of the manual.

For what it's worth, as soon as I can confirm this, I will make sure  
the publications team here at Freescale is made aware of the error so  
it can be corrected in the next printing of the manual.  I will also  
have the synchronization table updated as it also has incorrect  
information.

Thanks,
B

  parent reply	other threads:[~2006-05-31 23:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-29 10:59 Setting I&D cache enable in the same mtspr instruction Assaf Hoffman
2006-05-29 12:15 ` Roger Larsson
2006-05-30 18:27   ` Mark A. Greer
2006-05-31 23:06 ` Becky Bruce [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-29 12:37 Assaf Hoffman
2006-05-23  9:55 Assaf Hoffman
2006-05-23 22:34 ` Mark A. Greer
2006-05-08 10:39 Assaf Hoffman
2006-05-15 18:59 ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=687F6669-B58A-404A-9AC2-EDC34107F0EC@freescale.com \
    --to=becky.bruce@freescale.com \
    --cc=hoffman@marvell.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=rita@marvell.com \
    --cc=rshitrit@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).