Re: [PATCH 1/3] powerpc/irq: Move __softirq_pending out of irq_stat

["Christophe Leroy (CS GROUP)" <chleroy@kernel.org>]

Le 23/05/2026 à 19:40, Shrikanth Hegde a écrit :
> __softirq_pending isn't part of arch specific irq_stats. It is used
> by softirq core for various decision making such as whether to kick off
> ksoftirqd.
> 
> Move it out of irq_cpustat_t. This makes it simple to make irq_cpustat_t
> array based approach.

Some reference to commit 0fd7d8628529 ("softirq/core: Consolidate 
default local_softirq_pending() implementations") should be made I think 
for better understanding.

> 
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>



> ---
>   arch/powerpc/include/asm/hardirq.h | 3 ++-
>   arch/powerpc/kernel/irq.c          | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/include/asm/hardirq.h b/arch/powerpc/include/asm/hardirq.h
> index f133b5930ae1..bf3926a0c69c 100644
> --- a/arch/powerpc/include/asm/hardirq.h
> +++ b/arch/powerpc/include/asm/hardirq.h
> @@ -6,7 +6,6 @@
>   #include <linux/irq.h>
>   
>   typedef struct {
> -	unsigned int __softirq_pending;
>   	unsigned int timer_irqs_event;
>   	unsigned int broadcast_irqs_event;
>   	unsigned int timer_irqs_others;
> @@ -23,6 +22,8 @@ typedef struct {
>   } ____cacheline_aligned irq_cpustat_t;
>   
>   DECLARE_PER_CPU_SHARED_ALIGNED(irq_cpustat_t, irq_stat);
> +DECLARE_PER_CPU(unsigned int, __softirq_pending);
> +#define local_softirq_pending_ref       __softirq_pending
>   
>   #define __ARCH_IRQ_STAT
>   #define __ARCH_IRQ_EXIT_IRQS_DISABLED
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index a0e8b998c9b5..f33df5e5c23f 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -73,6 +73,7 @@
>   
>   DEFINE_PER_CPU_SHARED_ALIGNED(irq_cpustat_t, irq_stat);
>   EXPORT_PER_CPU_SYMBOL(irq_stat);
> +DEFINE_PER_CPU(unsigned int, __softirq_pending);
>   
>   #ifdef CONFIG_PPC32
>   atomic_t ppc_n_lost_interrupts;