From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] powerpc/signal: Use unsafe_copy_siginfo_to_user()
Date: Tue, 15 Jun 2021 09:00:58 +0200 [thread overview]
Message-ID: <68f4251c-2803-67b8-e8df-1a977ec368ba@csgroup.eu> (raw)
In-Reply-To: <YMhO4oiqh4F+ZEW8@infradead.org>
Le 15/06/2021 à 08:55, Christoph Hellwig a écrit :
>> @@ -836,14 +830,19 @@ int handle_rt_signal32(struct ksignal *ksig, sigset_t *oldset,
>> asm("dcbst %y0; sync; icbi %y0; sync" :: "Z" (mctx->mc_pad[0]));
>> }
>> unsafe_put_sigset_t(&frame->uc.uc_sigmask, oldset, failed);
>> +#ifndef CONFIG_COMPAT
>> + unsafe_copy_siginfo_to_user(&frame->info, &ksig->info, failed);
>> +#endif
>>
>> /* create a stack frame for the caller of the handler */
>> unsafe_put_user(regs->gpr[1], newsp, failed);
>>
>> user_access_end();
>>
>> - if (copy_siginfo_to_user(&frame->info, &ksig->info))
>> +#ifdef CONFIG_COMPAT
>> + if (copy_siginfo_to_user32(&frame->info, &ksig->info))
>> goto badframe;
>> +#endif
>
> Shouldn't the compat case be handled the same way?
>
It would be best, but it is not that easy to convert. So for the time being it is left aside, anyway
compat is for compatibility, so performance doesn't matter so much.
prev parent reply other threads:[~2021-06-15 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 6:40 [PATCH 1/7] powerpc/signal64: Copy siginfo before changing regs->nip Christophe Leroy
2021-06-15 6:40 ` [PATCH 2/7] powerpc/signal64: Don't read sigaction arguments back from user memory Christophe Leroy
2021-06-15 6:40 ` [PATCH 3/7] powerpc/signal64: Access function descriptor with user access block Christophe Leroy
2021-06-15 6:41 ` [PATCH 4/7] powerpc/signal: Include the new stack frame inside the " Christophe Leroy
2021-06-15 6:41 ` [PATCH 5/7] signal: Add unsafe_copy_siginfo_to_user() Christophe Leroy
2021-06-15 6:52 ` Christoph Hellwig
2021-06-15 7:03 ` Christophe Leroy
2021-06-15 7:21 ` Christoph Hellwig
2021-06-15 7:28 ` Christophe Leroy
2021-06-15 6:41 ` [PATCH 6/7] powerpc/uaccess: Add unsafe_clear_user() Christophe Leroy
2021-06-15 6:53 ` Christoph Hellwig
2021-06-15 7:10 ` Christophe Leroy
2021-06-15 6:41 ` [PATCH 7/7] powerpc/signal: Use unsafe_copy_siginfo_to_user() Christophe Leroy
2021-06-15 6:55 ` Christoph Hellwig
2021-06-15 7:00 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f4251c-2803-67b8-e8df-1a977ec368ba@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).