linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub
Date: Wed, 1 Aug 2007 00:10:28 +0200	[thread overview]
Message-ID: <692e6dabbfb62dc6d6ace3ea7552ef68@kernel.crashing.org> (raw)
In-Reply-To: <20070726135738.GB5643@localhost.localdomain>

> +			spi1pio:spi_pin@01 {

There should be whitespace after the label.  @01 should be
spelled @1.  Except there is no "reg" property.  What is this
stuff, anyway?

> +				pio-map = <
> +			/* port  pin  dir  open_drain  assignment  has_irq    */
> +					3  0  3  0  1  0	/* SPI1 MOSI, I/O */
> +					3  1  3  0  1  0	/* SPI1 MISO, I/O */
> +					3  2  3  0  1  0	/* SPI1 CLK,  I/O */
> +					3  3  2  0  1  0>;	/* SPI1 SEL,  I   */
> +			};


Segher

  parent reply	other threads:[~2007-07-31 22:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 13:57 [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub Anton Vorontsov
2007-07-26 15:36 ` Joakim Tjernlund
2007-07-26 15:47   ` Anton Vorontsov
2007-07-26 19:40     ` [RFC][PATCH] MPC832x_RDB: update dts to use spi, registermmc_spi stub Joakim Tjernlund
2007-07-27  7:55       ` Kumar Gala
2007-07-31 21:47       ` Segher Boessenkool
2007-07-27  8:14 ` [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub Kumar Gala
2007-07-27 11:45   ` Anton Vorontsov
2007-07-27 13:55     ` Kumar Gala
2007-07-27 16:40     ` Scott Wood
2007-07-31 22:00       ` Segher Boessenkool
2007-08-01 17:43         ` Scott Wood
2007-08-06 18:24           ` Segher Boessenkool
2007-07-31 22:06     ` Segher Boessenkool
2007-08-01 13:29       ` Anton Vorontsov
2007-08-06 18:18         ` Segher Boessenkool
2007-08-07 10:53           ` Anton Vorontsov
2007-08-07 16:11             ` Segher Boessenkool
2007-08-01 19:16       ` Kim Phillips
2007-08-06 18:25         ` Segher Boessenkool
2007-08-06 21:31           ` Kim Phillips
2007-08-06 22:08             ` Segher Boessenkool
2007-07-31 22:10 ` Segher Boessenkool [this message]
2007-08-01 12:34   ` Anton Vorontsov
2007-08-06 18:09     ` Segher Boessenkool
2007-08-06 18:50       ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=692e6dabbfb62dc6d6ace3ea7552ef68@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).