From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AA6C433F5 for ; Tue, 28 Sep 2021 21:03:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9646160230 for ; Tue, 28 Sep 2021 21:03:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9646160230 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HJsRq6nY5z2ypc for ; Wed, 29 Sep 2021 07:03:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=sathyanarayanan.kuppuswamy@linux.intel.com; receiver=) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HJsRJ6wsXz2xfy for ; Wed, 29 Sep 2021 07:03:08 +1000 (AEST) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="224843212" X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="224843212" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 14:02:00 -0700 X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="554303878" Received: from oogunmoy-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.221.219]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 14:01:58 -0700 Subject: Re: [PATCH v4 0/8] Implement generic cc_platform_has() helper function To: Borislav Petkov References: <20210928191009.32551-1-bp@alien8.de> <80593893-c63b-d481-45f1-42a3a6fd762a@linux.intel.com> <7319b756-55dc-c4d1-baf6-4686f0156ac4@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <695a3bf6-5382-68df-3ab5-8841b777fca2@linux.intel.com> Date: Tue, 28 Sep 2021 14:01:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, kvm@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Paul Mackerras , Will Deacon , Ard Biesheuvel , linux-s390@vger.kernel.org, Andi Kleen , Baoquan He , Joerg Roedel , x86@kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Christian Borntraeger , VMware Graphics , Dave Young , Tom Lendacky , Thomas Zimmermann , Vasily Gorbik , Heiko Carstens , Maarten Lankhorst , Maxime Ripard , Andy Lutomirski , "Kirill A. Shutemov" , kexec@lists.infradead.org, LKML , iommu@lists.linux-foundation.org, Daniel Vetter , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 9/28/21 1:58 PM, Borislav Petkov wrote: > On Tue, Sep 28, 2021 at 01:48:46PM -0700, Kuppuswamy, Sathyanarayanan wrote: >> Just read it. If you want to use cpuid_has_tdx_guest() directly in >> cc_platform_has(), then you want to rename intel_cc_platform_has() to >> tdx_cc_platform_has()? > > Why? > > You simply do: > > if (cpuid_has_tdx_guest()) > intel_cc_platform_has(...); > > and lemme paste from that mail: " ...you should use > cpuid_has_tdx_guest() instead but cache its result so that you don't > call CPUID each time the kernel executes cc_platform_has()." > > Makes sense? Yes. But, since the check is related to TDX, I just want to confirm whether you are fine with naming the function as intel_*(). Since this patch is going to have dependency on TDX code, I will include this patch in TDX patch set. > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer