* [PATCH] cpm_uart: Initialize port.dev before it's used.
@ 2009-04-03 20:48 Scott Wood
2009-04-06 14:09 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Scott Wood @ 2009-04-03 20:48 UTC (permalink / raw)
To: galak; +Cc: linuxppc-dev
Previously, this caused NULL to sometimes be passed as a device
to the DMA code. With recent DMA changes, that now causes a BUG().
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
This is a regression triggered by DMA changes; please apply for 2.6.30.
drivers/serial/cpm_uart/cpm_uart_core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c
index 5c6ef51..4dd00be 100644
--- a/drivers/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/serial/cpm_uart/cpm_uart_core.c
@@ -1339,13 +1339,13 @@ static int __devinit cpm_uart_probe(struct of_device *ofdev,
dev_set_drvdata(&ofdev->dev, pinfo);
+ /* initialize the device pointer for the port */
+ pinfo->port.dev = &ofdev->dev;
+
ret = cpm_uart_init_port(ofdev->node, pinfo);
if (ret)
return ret;
- /* initialize the device pointer for the port */
- pinfo->port.dev = &ofdev->dev;
-
return uart_add_one_port(&cpm_reg, &pinfo->port);
}
--
1.5.6.rc1.6.gc53ad.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpm_uart: Initialize port.dev before it's used.
2009-04-03 20:48 [PATCH] cpm_uart: Initialize port.dev before it's used Scott Wood
@ 2009-04-06 14:09 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2009-04-06 14:09 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Apr 3, 2009, at 3:48 PM, Scott Wood wrote:
> Previously, this caused NULL to sometimes be passed as a device
> to the DMA code. With recent DMA changes, that now causes a BUG().
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> This is a regression triggered by DMA changes; please apply for
> 2.6.30.
applied
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-06 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-03 20:48 [PATCH] cpm_uart: Initialize port.dev before it's used Scott Wood
2009-04-06 14:09 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).