linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "M B" <super.firetwister@googlemail.com>
To: netdev@vger.kernel.org
Cc: ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Phy read timeout in ibm_new_emac driver
Date: Wed, 16 Apr 2008 12:49:46 +0200	[thread overview]
Message-ID: <6a6049b80804160349q42120b4bs1c0db49ea5ad055d@mail.gmail.com> (raw)

The __emac_mdio_read function of the emac driver (core.c) will retry
100 times and wait 99us (until the last call of emac_phy_done). I
assume this is an off by one error.

	/* Wait for read to complete */
	n = 100;
	while (!emac_phy_done(dev, (r = in_be32(&p->stacr)))) {
		udelay(1);
		if (!--n) {
			DBG2(dev, " -> timeout wait complete\n");
			goto bail;
		}
	}

My Micrel/Kendin KSZ8721BT on my ppc405EP board needs one us longer to
finish. I was able to reproduce this all the time. So I wonder if the
timeout of 100us is defined by the MII standard, or by the author of
the driver?
If it's a standard I've still a bad feeling if we just correct the
timeout to 100us, maybe 110 should be fine. If it's not defined by the
standard, I would add 50% to the timeout. It won't slow down other
phys, but a scan on the phy bus might get slowed down.
Same applies for __emac_mdio_write.

Oh and we could save a us by putting the udelay(1) after the if section ;-)

Regards

Markus

             reply	other threads:[~2008-04-16 10:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16 10:49 M B [this message]
2008-04-16 12:09 ` Phy read timeout in ibm_new_emac driver Benjamin Herrenschmidt
2008-04-23  5:06   ` Markus Brunner
2008-04-23  5:18     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a6049b80804160349q42120b4bs1c0db49ea5ad055d@mail.gmail.com \
    --to=super.firetwister@googlemail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).