Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

[Madhavan Srinivasan <maddy@linux.vnet.ibm.com>]

On Friday 12 May 2017 09:03 AM, Michael Ellerman wrote:
> Stewart Smith <stewart@linux.vnet.ibm.com> writes:
>
>> Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
>>>>       * in patch 9 should opal_imc_counters_init return something other
>>>>         than OPAL_SUCCESS in the case on invalid arguments? Maybe
>>>>         OPAL_PARAMETER? (I think you fix this in a later patch anyway?)
>>> So, init call will return OPAL_PARAMETER for the unsupported
>>> domains (core and nest are supported). And if the init operation
>>> fails for any reason, it would return OPAL_HARDWARE. And this is
>>> documented.
>> (I'll comment on the skiboot one too), but I think that if the class
>> exists but init is a no-op, then OPAL_IMC_COUNTERS_INIT should return
>> OPAL_SUCCESS and just do nothing. This future proofs everything, and the
>> API is that one *must* call _INIT before start.
> Yes, 100%.
>
> That's what I described in my replies to a previous version, if it
> doesn't do that we need to fix it.
Hi mpe,

Yes, as you suggested in the opal v11 patchset, we return OPAL_SUCCESS
from _INIT for type "Nest". Have also added a prerror message logging
for debug, but can get away with it or make it as a prlog.

Maddy
>
> cheers
>