From: Milton Miller <miltonm@bga.com>
To: Scott Wood <scottwood@freescale.com>
Cc: ppcdev <linuxppc-dev@ozlabs.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 08/10] bootwrapper: Add a firmware-independent "raw" target.
Date: Mon, 10 Sep 2007 11:09:27 -0500 [thread overview]
Message-ID: <6c36dd35d7c6ee967223dc36ecf37d0c@bga.com> (raw)
In-Reply-To: <20070910142513.GB21670@ld0162-tx32.am.freescale.net>
On Sep 10, 2007, at 9:25 AM, Scott Wood wrote:
>>>> +static inline void disable_irq(void)
>>>> +{
>>>> + int dummy;
>>>> + asm volatile("mfmsr %0; rlwinm %0, %0, 0, ~(1<<15); mtmsr
>>>> %0"
>>>> :
>>>> + "=r" (dummy) : : "memory");
>>>> +}
>>
>> This will fail (mtmsr illegal instruction) on 64 bit processors that
>> do
>> not implement the bridge facility (POWER4, 5, 6, PPC970, ...)
>
> Ouch... And given the One wrapper.a To Rule Them All mandate, we can't
> ifdef it here, but instead must make separate platform files. :-P
Rather than a seperate c file, I think this should go in your
_zimage_start, renaming fixed-head.S.
milton
next prev parent reply other threads:[~2007-09-10 16:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 19:20 [PATCH 00/10] Bootwrapper patches Scott Wood
2007-09-05 19:21 ` [PATCH 01/10] bootwrapper: Use fsl_get_immr() in cuboot-pq2.c Scott Wood
2007-09-05 19:21 ` [PATCH 02/10] bootwrapper: Support all-in-one PCI nodes in cuboot-pq2 Scott Wood
2007-09-05 19:21 ` [PATCH 03/10] bootwrapper: flatdevtree fixes Scott Wood
2007-09-07 0:49 ` David Gibson
2007-09-05 19:21 ` [PATCH 04/10] bootwrapper: Add strtoull() Scott Wood
2007-09-05 21:12 ` Josh Boyer
2007-09-07 0:50 ` David Gibson
2007-09-05 19:21 ` [PATCH 05/10] bootwrapper: Add get_path() Scott Wood
2007-09-07 0:52 ` David Gibson
2007-09-05 19:21 ` [PATCH 06/10] bootwrapper: Move strncmp() from flatdevtree_env.h to string.S/string.h Scott Wood
2007-09-07 0:51 ` David Gibson
2007-09-07 14:24 ` Scott Wood
2007-09-05 19:21 ` [PATCH 07/10] bootwrapper: Add PlanetCore firmware support Scott Wood
2007-09-07 1:03 ` David Gibson
2007-09-05 19:21 ` [PATCH 08/10] bootwrapper: Add a firmware-independent "raw" target Scott Wood
2007-09-07 0:58 ` David Gibson
2007-09-09 23:29 ` Milton Miller
2007-09-10 14:25 ` Scott Wood
2007-09-10 14:30 ` Scott Wood
2007-09-10 16:01 ` Milton Miller
2007-09-10 16:09 ` Milton Miller [this message]
2007-09-10 21:17 ` Segher Boessenkool
2007-09-21 17:31 ` Grant Likely
2007-09-21 17:33 ` Scott Wood
2007-10-03 20:29 ` Grant Likely
2007-09-05 19:21 ` [PATCH 09/10] bootwrapper: Only print MAC addresses when the node is actually present Scott Wood
2007-09-07 0:52 ` David Gibson
2007-09-05 19:21 ` [PATCH 10/10] bootwrapper: Add fsl_get_immr() and 8xx/pq2 clock functions Scott Wood
2007-09-07 0:53 ` David Gibson
2007-09-07 14:26 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c36dd35d7c6ee967223dc36ecf37d0c@bga.com \
--to=miltonm@bga.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).