From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDCB6F01832 for ; Fri, 6 Mar 2026 12:25:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fS5Fr2TPqz3cB3; Fri, 06 Mar 2026 23:25:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772799168; cv=none; b=bqLVdyLLUa1nKV2aBuroOPrT4FNzTC43JszVxpBvJMTGcDukXLe84L2yudU7iBu59Cg3rnXZ+fmrcPrT6Kl5P1szUYFW8MaDDk7goHqsEJPM1PP+mKF5E2QexA4QUHPggND+O8I84O4FWN/e2Ws0tbuxN5vg9WjV2q/1MbOnckKjBynchloPCNRiT74msHrfwU0lDmuDJC4aw880X8sXWqkpPqUZ4NL3o44rhdub9UZcGwdvzWfZA4jolmOZ8eNbSN6BmZrrYR9K1JvYtjz3ELA9dGsFvNxz4ySO+rLz4+83Bbl8EbnSF4yMSzRD78AZcpw/Xxl2UVLrHhmbNc7ilg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772799168; c=relaxed/relaxed; bh=FmHWyx9rv+vFIzYL5aWwe4zaNcFlh4tAsVu3dhL4NP4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n2u527JO/FlCjY9R3KnIqtQtHJXfvY6ixFQuiv0DUCp3AWIJpWzFgORwHYLHSWDFBbH6T7vGQGbxNDS3uFOWtcS6yn8En3EKsBjQ0wQOd7KHXbA7taGW4/zvCLtUGeUQTKsnKoEzw1C2R/Wn0S4Z4skcSpU4Ej+Pnur+hMBHQlby3vNa7csUXQwUskU6HVyIQswqMwR0BHvT3hoPr32700V1XIFWr54JTllPKW9E8NALj0maCECwqsgd+1F+lazIdFAb35wu6j5j7SFC7YXJHR96Un1HeJiZMOUQi0cV+KGiYdHhXH37BPyDzQGS/qVXmHR7x9ErHy9WP9tyMKgm2Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=edn61naH; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=edn61naH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fS4zg4ZsYz30T9 for ; Fri, 06 Mar 2026 23:12:47 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7DDE84074C; Fri, 6 Mar 2026 12:12:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C62C0C2BCAF; Fri, 6 Mar 2026 12:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772799165; bh=0pXAFOIFGu2oV25L8o52sQR97OfC/9uMSwkci4VWiEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=edn61naHlNfCj6ZsP5AwEUGw9CwfdJ2+qp4E3P9NrRqaex7Mzs8I9+4N3Nb8iPzP+ MDPjuNK9A6Qetf2KX0tPdvyQxuXEHgWgnJamhiPEMXHArV5hNb6HubqUE67/ScusgV 91Op1mHTejDA5unrODiPadH1XnhaGXoJamDx/1ZP/XFup2VlHpsi86fd3iVR7t4ble +R8KS6ktipoGCS0QCYK2SAjgpa//+C9kqsjUElB2UcpnwNnT+t6UY96TQdEfREXxm8 O4hbjLTlhFJ/5gK3fCzWdjUFddgW6o4Vk83yvQglRcCnELrZY+0WRVW3GmusGUbG5S PqwmeKjYrR3zQ== Date: Fri, 6 Mar 2026 12:12:42 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 04/16] mm/memory: simplify calculation in unmap_mapping_range_tree() Message-ID: <6c6bf2d6-bc0f-4721-a57d-6b9c5f2a5c66@lucifer.local> References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-5-david@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227200848.114019-5-david@kernel.org> On Fri, Feb 27, 2026 at 09:08:35PM +0100, David Hildenbrand (Arm) wrote: > Let's simplify the calculation a bit further to make it easier to get, > reusing vma_last_pgoff() which we move from interval_tree.c to mm.h. > > Signed-off-by: David Hildenbrand (Arm) Thanks, some crusty old code here much improved. LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > include/linux/mm.h | 5 +++++ > mm/interval_tree.c | 5 ----- > mm/memory.c | 12 +++++------- > 3 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a8138ff7d1fa..d3ef586ee1c0 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4000,6 +4000,11 @@ static inline unsigned long vma_pages(const struct vm_area_struct *vma) > return (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > } > > +static inline unsigned long vma_last_pgoff(struct vm_area_struct *vma) > +{ > + return vma->vm_pgoff + vma_pages(vma) - 1; > +} > + > static inline unsigned long vma_desc_size(const struct vm_area_desc *desc) > { > return desc->end - desc->start; > diff --git a/mm/interval_tree.c b/mm/interval_tree.c > index 32e390c42c53..32bcfbfcf15f 100644 > --- a/mm/interval_tree.c > +++ b/mm/interval_tree.c > @@ -15,11 +15,6 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v) > return v->vm_pgoff; > } > > -static inline unsigned long vma_last_pgoff(struct vm_area_struct *v) > -{ > - return v->vm_pgoff + vma_pages(v) - 1; > -} > - > INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb, > unsigned long, shared.rb_subtree_last, > vma_start_pgoff, vma_last_pgoff, /* empty */, vma_interval_tree) > diff --git a/mm/memory.c b/mm/memory.c > index 5c47309331f5..e4154f03feac 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4227,17 +4227,15 @@ static inline void unmap_mapping_range_tree(struct rb_root_cached *root, > struct zap_details *details) > { > struct vm_area_struct *vma; > - pgoff_t vba, vea, zba, zea; > unsigned long start, size; > struct mmu_gather tlb; > > vma_interval_tree_foreach(vma, root, first_index, last_index) { > - vba = vma->vm_pgoff; > - vea = vba + vma_pages(vma) - 1; > - zba = max(first_index, vba); > - zea = min(last_index, vea); These variable names... Lord. > - start = ((zba - vba) << PAGE_SHIFT) + vma->vm_start; > - size = (zea - zba + 1) << PAGE_SHIFT; > + const pgoff_t start_idx = max(first_index, vma->vm_pgoff); > + const pgoff_t end_idx = min(last_index, vma_last_pgoff(vma)) + 1; I guess since 'end' is by-convention the +1 of last this is fine > + > + start = vma->vm_start + ((start_idx - vma->vm_pgoff) << PAGE_SHIFT); > + size = (end_idx - start_idx) << PAGE_SHIFT; > > tlb_gather_mmu(&tlb, vma->vm_mm); > zap_page_range_single_batched(&tlb, vma, start, size, details); > -- > 2.43.0 >