From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD50CC4338F for ; Mon, 23 Aug 2021 06:39:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 215E460FD9 for ; Mon, 23 Aug 2021 06:39:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 215E460FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GtMzw0hxlz2xvS for ; Mon, 23 Aug 2021 16:39:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Zwogo5FV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com; envelope-from=hkallweit1@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Zwogo5FV; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GtMz611Qdz2xh1 for ; Mon, 23 Aug 2021 16:39:12 +1000 (AEST) Received: by mail-wm1-x329.google.com with SMTP id x2-20020a1c7c02000000b002e6f1f69a1eso13216959wmc.5 for ; Sun, 22 Aug 2021 23:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9Aqx6TrlbZceHPQbmc0/vVBBjQ3l0UdYj3Xf1scJT9g=; b=Zwogo5FVzcC7NwjXJqrHozJwSSJT6SkwkkRaLGmVuXXsEwjPid23+cAr+HYJbZxXcP KlcYdH8AGH1bMMdOb/wxt0SeNbbtTil9jwllHagrbP1q5tXaxzVtjnF678nqODGQLOwA cUOgqaBt6Dg/NmcIu83IFsY3WfJTr5GxoMGcjrCldAZcGf91eKZXpr4fV1axoGsWnEad 7FfIp/drEXmvltW6Tb1ci6OyOObW0chzEcKcqJv+Hooz4VLcg9EelG55xiNM3RK+s+YP WF/eySEYI4DeTBveMaQze2s8KrvVPV24+fYTgLCHXjw2ofixBDFiFAp0omSl7xW77OqL 5leg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9Aqx6TrlbZceHPQbmc0/vVBBjQ3l0UdYj3Xf1scJT9g=; b=LZn2lFOYZszjH7h74BNNDr+394Gko3ziQdEuY1X/m1+5FFtE6Ve1I5qAaFNaN0QnQn MFys4sybWmZ1Hfzti4IghOLkD+P5lxptP1XLJAblBRKj78qWkjliGHUjDw6dOm0DXdq+ w+a5z976ZwPwxOjaAMDh0ZmGJhyNi+xXRP4IJxHf5mZFGp8QuK1h1ahBfalhBdL+uJVI QUTa6HJT3SETVskHmA8f5uHqgjKtdjm5mvQXRHprqeao8knMqfJFS6jPstNC1AAhdg8n 8K6VW06CiSY42pDjc3mc5F1BgwD2VzZJ/lUGmJsZHA9l36dWIC8LLU1ffFGhp13UytGM A6kQ== X-Gm-Message-State: AOAM5309eoY6POvRNUR3LLdJdOPI/tLQbf0KFIn9Ri9Q6gomuQwo4RRY /vG9fIdgUrARDdyUMzoT/1o= X-Google-Smtp-Source: ABdhPJxMDl5C5Iu83116CuHInV6lPElsLuPvoM9TmHB5RgepZKEne1VQji9BlkhaP8jrwX7mJv97Jw== X-Received: by 2002:a1c:f414:: with SMTP id z20mr14939054wma.94.1629700746294; Sun, 22 Aug 2021 23:39:06 -0700 (PDT) Received: from ?IPv6:2003:ea:8f08:4500:ed43:740c:fec5:7f46? (p200300ea8f084500ed43740cfec57f46.dip0.t-ipconnect.de. [2003:ea:8f08:4500:ed43:740c:fec5:7f46]) by smtp.googlemail.com with ESMTPSA id u16sm13947028wmc.41.2021.08.22.23.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Aug 2021 23:39:05 -0700 (PDT) Subject: Re: [net-next][bisected da41788] modules fails to build drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199 To: Abdul Haleem , davem@davemloft.net, netdev@vger.kernel.org References: <16a5465e-2357-3277-e2eb-dc0668e6cb01@linux.vnet.ibm.com> From: Heiner Kallweit Message-ID: <6c87b191-13c3-c52d-34ad-79e23b5d71a6@gmail.com> Date: Mon, 23 Aug 2021 08:38:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <16a5465e-2357-3277-e2eb-dc0668e6cb01@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian King , kuba@kernel.org, linuxppc-dev , linux-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 23.08.2021 08:00, Abdul Haleem wrote: > Greeting's > > Todays net-next branch fails to build on my powerpc box with below error > >   CC [M]  drivers/gpu/drm/virtio/virtgpu_trace_points.o >   CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.o > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function ‘bnx2x_read_fwinfo’: > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199:13: error: implicit declaration of function ‘pci_vpd_alloc’; did you mean ‘pci_pool_alloc’? [-Werror=implicit-function-declaration] >   vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len); >              ^~~~~~~~~~~~~ >              pci_pool_alloc > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12199:11: warning: assignment to ‘u8 *’ {aka ‘unsigned char *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion] >   vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len); >            ^ >   CC [M]  drivers/scsi/qla2xxx/qla_nx.o >   CC [M]  net/netfilter/xt_MASQUERADE.o >   CC [M]  net/bluetooth/ecdh_helper.o >   CC [M]  drivers/gpu/drm/amd/amdgpu/uvd_v5_0.o > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12203:9: error: implicit declaration of function ‘pci_vpd_find_ro_info_keyword’; did you mean ‘pci_vpd_find_info_keyword’? [-Werror=implicit-function-declaration] >   rodi = pci_vpd_find_ro_info_keyword(vpd_data, vpd_len, >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >          pci_vpd_find_info_keyword >   CC [M]  net/netfilter/xt_SECMARK.o >   CC [M]  net/netfilter/xt_TPROXY.o >   CC [M]  net/mac80211/driver-ops.o > > > The recent changes to the code causing build fail is > > commit da417885a99d36036cc7d2778f94b846e6582434 > Author: Heiner Kallweit > Date:   Sun Aug 22 15:54:23 2021 +0200 > >     bnx2x: Search VPD with pci_vpd_find_ro_info_keyword() >         Use pci_vpd_find_ro_info_keyword() to search for keywords in VPD to >     simplify the code. >         str_id_reg and str_id_cap hold the same string and are used in the same >     comparison. This doesn't make sense, use one string str_id instead. >         Signed-off-by: Heiner Kallweit >     Signed-off-by: David S. Miller > > @Heiner, Could you please have a look, I am attaching the kernel config > This series was supposed to go via the PCI tree because it builds on patches that are in the PCI tree but not in linux-next and net-next yet.