From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH 3/3] mm/hugetlb: Remove pmd_huge_split_prepare
Date: Thu, 27 Jul 2017 21:27:37 +0530 [thread overview]
Message-ID: <6d836bdb-0bf4-e855-e3d8-01a622714d1b@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170727125756.GD27766@dhcp22.suse.cz>
On 07/27/2017 06:27 PM, Michal Hocko wrote:
> On Thu 27-07-17 14:07:56, Aneesh Kumar K.V wrote:
>> Instead of marking the pmd ready for split, invalidate the pmd. This should
>> take care of powerpc requirement.
>
> which is?
I can add the commit which explain details here. Or add more details
from the older commit here.
c777e2a8b65420b31dac28a453e35be984f5808b
powerpc/mm: Fix Multi hit ERAT cause by recent THP update
>
>> Only side effect is that we mark the pmd
>> invalid early. This can result in us blocking access to the page a bit longer
>> if we race against a thp split.
>
> Again, this doesn't tell me what is the problem and why do we care.
Primary motivation is code reduction.
7 files changed, 35 insertions(+), 87 deletions(-)
-aneesh
next prev parent reply other threads:[~2017-07-27 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 8:37 [RFC PATCH 1/3] powerpc/mm: update pmdp_invalidate to return old pmd value Aneesh Kumar K.V
2017-07-27 8:37 ` [RFC PATCH 2/3] powerpc/mm: Implement pmdp_establish for ppc64 Aneesh Kumar K.V
2017-07-27 12:56 ` Michal Hocko
2017-07-27 15:52 ` Aneesh Kumar K.V
2017-07-27 8:37 ` [RFC PATCH 3/3] mm/hugetlb: Remove pmd_huge_split_prepare Aneesh Kumar K.V
2017-07-27 10:50 ` Aneesh Kumar K.V
2017-07-27 12:57 ` Michal Hocko
2017-07-27 15:57 ` Aneesh Kumar K.V [this message]
2017-07-28 7:04 ` Michal Hocko
2017-07-27 12:54 ` [RFC PATCH 1/3] powerpc/mm: update pmdp_invalidate to return old pmd value Michal Hocko
2017-07-27 12:58 ` Kirill A. Shutemov
2017-07-27 15:48 ` Aneesh Kumar K.V
2017-07-28 7:01 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d836bdb-0bf4-e855-e3d8-01a622714d1b@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).