From: Segher Boessenkool <segher@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v4]: Fix e500 v2 core reboot bug
Date: Wed, 13 Jun 2007 09:03:37 +0200 [thread overview]
Message-ID: <6dc1593b8ff8442f7b4cf7a01f69c07c@kernel.crashing.org> (raw)
In-Reply-To: <1181717615.9397.40.camel@localhost.localdomain>
> Fix the reset bug on 8548CDS board.
> Segher, do you have any comment?
This one looks fine, only some cosmetics left :-)
> If yes, I will revise again; if No, pick it up!
Well it's not me who picks things up around here...
> + printk (KERN_EMERG "Error: reset control \
> + register not mapped, spinning!\n");
...(... "bla bla bla "
"bla bla bla\n");
instead? Or there'll be a lot of whitespace in your string.
I don't see anything spinning like the warning says, btw (or
it must be something in abort()?)
Segher
next prev parent reply other threads:[~2007-06-13 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 6:53 [PATCH v4]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-06-13 7:03 ` Segher Boessenkool [this message]
2007-06-13 7:14 ` Zang Roy-r61911
2007-06-13 7:26 ` Segher Boessenkool
2007-06-13 7:43 ` Zang Roy-r61911
2007-06-13 7:49 ` Li Yang-r58472
2007-06-13 7:55 ` Segher Boessenkool
2007-06-13 8:07 ` Zang Roy-r61911
2007-06-13 8:16 ` Li Yang-r58472
2007-06-13 9:13 ` Zang Roy-r61911
2007-06-14 13:26 ` Kumar Gala
2007-06-13 7:54 ` Segher Boessenkool
2007-06-13 8:27 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc1593b8ff8442f7b4cf7a01f69c07c@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).