From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH 05/19] powerpc/32: Use load and store multiple in GPR save/restore macros
Date: Thu, 3 Nov 2022 08:26:45 +0000 [thread overview]
Message-ID: <6dd19b06-f967-7643-0857-88c92bf1ea79@csgroup.eu> (raw)
In-Reply-To: <20221031055440.3594315-6-npiggin@gmail.com>
It contradicts commit a85c728cb5e1 ("powerpc/32: Don't use lmw/stmw for
saving/restoring non volatile regs")
Le 31/10/2022 à 06:54, Nicholas Piggin a écrit :
> ---
> arch/powerpc/include/asm/ppc_asm.h | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/ppc_asm.h b/arch/powerpc/include/asm/ppc_asm.h
> index 753a2757bcd4..ac44383d350a 100644
> --- a/arch/powerpc/include/asm/ppc_asm.h
> +++ b/arch/powerpc/include/asm/ppc_asm.h
> @@ -57,8 +57,22 @@
> #define SAVE_NVGPRS(base) SAVE_GPRS(14, 31, base)
> #define REST_NVGPRS(base) REST_GPRS(14, 31, base)
> #else
> -#define SAVE_GPRS(start, end, base) OP_REGS stw, 4, start, end, base, GPR0
> -#define REST_GPRS(start, end, base) OP_REGS lwz, 4, start, end, base, GPR0
> +.macro __SAVE_GPRS start, end, base, offset
> + .if \end == 31
> + stmw \start,\offset(\base)
> + .else
> + OP_REGS stw, 4, \start, \end, \base, \offset
> + .endif
> +.endm
> +.macro __REST_GPRS start, end, base, offset
> + .if \end == 31
> + lmw \start,\offset(\base)
> + .else
> + OP_REGS lwz, 4, \start, \end, \base, \offset
> + .endif
> +.endm
> +#define SAVE_GPRS(start, end, base) __SAVE_GPRS start, end, base, GPR0
> +#define REST_GPRS(start, end, base) __REST_GPRS start, end, base, GPR0
> #define SAVE_NVGPRS(base) SAVE_GPRS(13, 31, base)
> #define REST_NVGPRS(base) REST_GPRS(13, 31, base)
> #endif
next prev parent reply other threads:[~2022-11-03 8:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 5:54 [RFC PATCH 00/19] Remove STACK_FRAME_OVERHEAD Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 01/19] powerpc/perf: callchain validate kernel stack pointer bounds Nicholas Piggin
2022-11-04 13:10 ` Segher Boessenkool
2022-10-31 5:54 ` [RFC PATCH 02/19] powerpc: Rearrange copy_thread child stack creation Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 03/19] powerpc/64: Remove asm interrupt tracing call helpers Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 04/19] powerpc/pseries: hvcall stack frame overhead Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 05/19] powerpc/32: Use load and store multiple in GPR save/restore macros Nicholas Piggin
2022-11-03 8:26 ` Christophe Leroy [this message]
2022-11-07 12:45 ` Nicholas Piggin
2022-11-07 12:51 ` Christophe Leroy
2022-10-31 5:54 ` [RFC PATCH 06/19] powerpc: simplify ppc_save_regs Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 07/19] powerpc: add definition for pt_regs offset within an interrupt frame Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 08/19] powerpc: add a definition for the marker offset within the " Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 09/19] powerpc: Rename STACK_FRAME_MARKER and derive it from frame offset Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 10/19] powerpc: add a define for the user interrupt frame size Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 11/19] powerpc: add a define for the switch frame size and regs offset Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 12/19] powerpc: copy_thread fill in interrupt frame marker and back chain Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 13/19] powerpc: copy_thread add a back chain to the switch stack frame Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 14/19] powerpc: split validate_sp into two functions Nicholas Piggin
2022-11-07 0:58 ` Russell Currey
2022-11-07 12:29 ` Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 15/19] powerpc: allow minimum sized kernel stack frames Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 16/19] powerpc/64: ELFv2 use minimal stack frames in int and switch frame sizes Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 17/19] powerpc: remove STACK_FRAME_OVERHEAD Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 18/19] powerpc: change stack marker memory operations to 32-bit Nicholas Piggin
2022-10-31 5:54 ` [RFC PATCH 19/19] powerpc/64: ELFv2 use reserved word in the stack frame for the regs marker Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd19b06-f967-7643-0857-88c92bf1ea79@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).