From: Milton Miller <miltonm@bga.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: use common cpu_die
Date: Fri, 6 Feb 2009 11:02:34 -0600 [thread overview]
Message-ID: <6eae2dfd216825bd50e057005780ca5e@bga.com> (raw)
In-Reply-To: <1233720433.16867.185.camel@pasglop>
On Feb 3, 2009, at 10:07 PM, Benjamin Herrenschmidt wrote:
>> --- work.git.orig/arch/powerpc/platforms/powermac/setup.c-static void
>> pmac_cpu_die(void)
>> +static void pmac64_cpu_die(void)
...
>> --- work.git.orig/arch/powerpc/platforms/powermac/smp.c 2009-01-05
>> 02:09:08.000000000 -0600
>> -void cpu_die(void)
>> +void pmac32_cpu_die(void)
>> {
>> local_irq_disable();
>> cpu_dead[smp_processor_id()] = 1;
>
> Hi Milton ! Any chance you can move both pmac32 and pmac64 variants
> into
> the same file ?
I'm sure I could, but (1) it should be an incremental patch, (2) it
would only be compile tested again, and (3) I didn't look to see how
it would fit. I was doing the minimal patch that left the code intact;
it's possible that more consolidation could be done.
milton
prev parent reply other threads:[~2009-02-06 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 0:07 cpu_die on MPC8641D Matt Sealey
2009-01-05 3:06 ` Matt Sealey
2009-01-05 13:05 ` [PATCH] powerpc: use common cpu_die Milton Miller
2009-01-06 0:47 ` Matt Sealey
2009-01-06 14:28 ` Milton Miller
2009-02-04 4:07 ` Benjamin Herrenschmidt
2009-02-06 17:02 ` Milton Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eae2dfd216825bd50e057005780ca5e@bga.com \
--to=miltonm@bga.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).