From: Andrew Donnellan <ajd@linux.ibm.com>
To: Benjamin Gray <bgray@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: jniethe5@gmail.com, cmr@bluescreens.de, npiggin@gmail.com
Subject: Re: [PATCH v10 3/9] powerpc/mm: Remove extern from function prototypes
Date: Fri, 25 Nov 2022 14:12:59 +1100 [thread overview]
Message-ID: <6f68606c4ff2eb94439eff22f41a7db8d438268c.camel@linux.ibm.com> (raw)
In-Reply-To: <20221109045112.187069-4-bgray@linux.ibm.com>
On Wed, 2022-11-09 at 15:51 +1100, Benjamin Gray wrote:
> Remove the extern keyword from function declarations. It is redundant
> and would cause inconsistent style when new functions are added
> without
> it.
>
> Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> v10: * New in v10 for consistency with new functions
> ---
> .../include/asm/book3s/64/tlbflush-hash.h | 19 +++++++++--------
> -
> arch/powerpc/include/asm/nohash/tlbflush.h | 20 +++++++++--------
> --
> 2 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
> b/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
> index fab8332fe1ad..3c89e625e620 100644
> --- a/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
> +++ b/arch/powerpc/include/asm/book3s/64/tlbflush-hash.h
> @@ -22,7 +22,7 @@ struct ppc64_tlb_batch {
> };
> DECLARE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch);
>
> -extern void __flush_tlb_pending(struct ppc64_tlb_batch *batch);
> +void __flush_tlb_pending(struct ppc64_tlb_batch *batch);
>
> #define __HAVE_ARCH_ENTER_LAZY_MMU_MODE
>
> @@ -51,14 +51,13 @@ static inline void arch_leave_lazy_mmu_mode(void)
>
> #define arch_flush_lazy_mmu_mode() do {} while (0)
>
> -extern void hash__tlbiel_all(unsigned int action);
> +void hash__tlbiel_all(unsigned int action);
>
> -extern void flush_hash_page(unsigned long vpn, real_pte_t pte, int
> psize,
> - int ssize, unsigned long flags);
> -extern void flush_hash_range(unsigned long number, int local);
> -extern void flush_hash_hugepage(unsigned long vsid, unsigned long
> addr,
> - pmd_t *pmdp, unsigned int psize, int
> ssize,
> - unsigned long flags);
> +void flush_hash_page(unsigned long vpn, real_pte_t pte, int psize,
> int ssize,
> + unsigned long flags);
> +void flush_hash_range(unsigned long number, int local);
> +void flush_hash_hugepage(unsigned long vsid, unsigned long addr,
> pmd_t *pmdp,
> + unsigned int psize, int ssize, unsigned long
> flags);
> static inline void hash__local_flush_tlb_mm(struct mm_struct *mm)
> {
> }
> @@ -111,11 +110,11 @@ static inline void
> hash__flush_tlb_kernel_range(unsigned long start,
>
>
> struct mmu_gather;
> -extern void hash__tlb_flush(struct mmu_gather *tlb);
> +void hash__tlb_flush(struct mmu_gather *tlb);
>
> #ifdef CONFIG_PPC_64S_HASH_MMU
> /* Private function for use by PCI IO mapping code */
> -extern void __flush_hash_table_range(unsigned long start, unsigned
> long end);
> +void __flush_hash_table_range(unsigned long start, unsigned long
> end);
> void flush_hash_table_pmd_range(struct mm_struct *mm, pmd_t *pmd,
> unsigned long addr);
> #else
> static inline void __flush_hash_table_range(unsigned long start,
> unsigned long end) { }
> diff --git a/arch/powerpc/include/asm/nohash/tlbflush.h
> b/arch/powerpc/include/asm/nohash/tlbflush.h
> index bdaf34ad41ea..0cef5e4f8d92 100644
> --- a/arch/powerpc/include/asm/nohash/tlbflush.h
> +++ b/arch/powerpc/include/asm/nohash/tlbflush.h
> @@ -28,8 +28,7 @@ struct mm_struct;
>
> #define MMU_NO_CONTEXT ((unsigned int)-1)
>
> -extern void flush_tlb_range(struct vm_area_struct *vma, unsigned
> long start,
> - unsigned long end);
> +void flush_tlb_range(struct vm_area_struct *vma, unsigned long
> start, unsigned long end);
>
> #ifdef CONFIG_PPC_8xx
> static inline void local_flush_tlb_mm(struct mm_struct *mm)
> @@ -55,19 +54,18 @@ static inline void
> flush_tlb_kernel_range(unsigned long start, unsigned long end
> asm volatile ("sync; tlbia; isync" : : : "memory");
> }
> #else
> -extern void flush_tlb_kernel_range(unsigned long start, unsigned
> long end);
> -extern void local_flush_tlb_mm(struct mm_struct *mm);
> -extern void local_flush_tlb_page(struct vm_area_struct *vma,
> unsigned long vmaddr);
> +void flush_tlb_kernel_range(unsigned long start, unsigned long end);
> +void local_flush_tlb_mm(struct mm_struct *mm);
> +void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long
> vmaddr);
>
> -extern void __local_flush_tlb_page(struct mm_struct *mm, unsigned
> long vmaddr,
> - int tsize, int ind);
> +void __local_flush_tlb_page(struct mm_struct *mm, unsigned long
> vmaddr,
> + int tsize, int ind);
> #endif
>
> #ifdef CONFIG_SMP
> -extern void flush_tlb_mm(struct mm_struct *mm);
> -extern void flush_tlb_page(struct vm_area_struct *vma, unsigned long
> vmaddr);
> -extern void __flush_tlb_page(struct mm_struct *mm, unsigned long
> vmaddr,
> - int tsize, int ind);
> +void flush_tlb_mm(struct mm_struct *mm);
> +void flush_tlb_page(struct vm_area_struct *vma, unsigned long
> vmaddr);
> +void __flush_tlb_page(struct mm_struct *mm, unsigned long vmaddr,
> int tsize, int ind);
> #else
> #define flush_tlb_mm(mm) local_flush_tlb_mm(mm)
> #define
> flush_tlb_page(vma,addr) local_flush_tlb_page(vma,addr)
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2022-11-25 3:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 4:51 [PATCH v10 0/9] powerpc/code-patching: Use temporary mm for Radix MMU Benjamin Gray
2022-11-09 4:51 ` [PATCH v10 1/9] powerpc: Allow clearing and restoring registers independent of saved breakpoint state Benjamin Gray
2022-11-09 4:51 ` [PATCH v10 2/9] powerpc/code-patching: Use WARN_ON and fix check in poking_init Benjamin Gray
2022-11-09 6:12 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 3/9] powerpc/mm: Remove extern from function prototypes Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-25 3:12 ` Andrew Donnellan [this message]
2022-11-09 4:51 ` [PATCH v10 4/9] powerpc/mm: Remove empty hash__ functions Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 5/9] cxl: Use radix__flush_all_mm instead of generic flush_all_mm Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-25 2:42 ` Andrew Donnellan
2022-11-09 4:51 ` [PATCH v10 6/9] powerpc/mm: Remove flush_all_mm, local_flush_all_mm Benjamin Gray
2022-11-09 6:17 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 7/9] powerpc/tlb: Add local flush for page given mm_struct and psize Benjamin Gray
2022-11-09 6:18 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 8/9] powerpc/code-patching: Use temporary mm for Radix MMU Benjamin Gray
2022-12-15 20:17 ` Nathan Chancellor
2022-12-16 0:23 ` Michael Ellerman
2022-11-09 4:51 ` [PATCH v10 9/9] powerpc/code-patching: Consolidate and cache per-cpu patching context Benjamin Gray
2022-11-09 6:23 ` Christophe Leroy
2022-12-08 12:39 ` [PATCH v10 0/9] powerpc/code-patching: Use temporary mm for Radix MMU Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f68606c4ff2eb94439eff22f41a7db8d438268c.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=bgray@linux.ibm.com \
--cc=cmr@bluescreens.de \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).