From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH RFT] powerpc/8xx: implement get_direction() in cpm1
Date: Thu, 4 Jun 2026 12:07:48 +0200 [thread overview]
Message-ID: <6f8df5e0-f630-40da-b94e-77202028d687@kernel.org> (raw)
In-Reply-To: <CAMRc=Mf-AeKDn6hi_jM99BLPaDXd04pgkUyuncuUBb2Kn-1mMw@mail.gmail.com>
Le 04/06/2026 à 11:53, Bartosz Golaszewski a écrit :
> On Thu, 4 Jun 2026 10:24:27 +0200, "Christophe Leroy (CS GROUP)"
> <chleroy@kernel.org> said:
>>
>>
>> Le 03/06/2026 à 10:26, Bartosz Golaszewski a écrit :
>>> The lack of get_direction() callbacks in this driver causes GPIOLIB to
>>> emit a warning. Implement them for 16- and 32-bit variants.
>>>
>>> Reported-by: Christophe Leroy <chleroy@kernel.org>
>>> Closes: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F63487206f6e5a93eaf9f41784317fe99d394312f.1780399750.git.chleroy%40kernel.org%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C94897fc3d78242b6193308dec21f300e%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639161636389791222%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=an4ji%2Bk24tiNfOASUmnvOyp6kLJzRlH8qhihSkGp%2BVc%3D&reserved=0
>
> What happened here??
Ask Bill Gates.
My company uses Microsoft 365 outlook, it mangles all links included in
emails for security reasons they say, to minimise phishing.
>
>>> Fixes: ec2cceadfae7 ("gpiolib: normalize the return value of gc->get() on behalf of buggy drivers")
>>
>> Isn't it e623c4303ed1 ("gpiolib: sanitize the return value of
>> gpio_chip::get_direction()") ?
>>
>
> Sure, can be:
>
> Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of
> gpio_chip::get_direction()")
>
> Bart
prev parent reply other threads:[~2026-06-04 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 8:26 [PATCH RFT] powerpc/8xx: implement get_direction() in cpm1 Bartosz Golaszewski
2026-06-04 7:51 ` Christophe Leroy (CS GROUP)
2026-06-04 8:19 ` Linus Walleij
2026-06-04 8:20 ` Linus Walleij
2026-06-04 8:24 ` Christophe Leroy (CS GROUP)
2026-06-04 9:53 ` Bartosz Golaszewski
2026-06-04 10:07 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8df5e0-f630-40da-b94e-77202028d687@kernel.org \
--to=chleroy@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox