linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: fix MAC address entries for 83xx, 85xx, and 86xx device trees
Date: Sat, 23 Jun 2007 17:50:23 +0200	[thread overview]
Message-ID: <70d005ce549921cc56481fe0b26faaa4@kernel.crashing.org> (raw)
In-Reply-To: <11825407952085-git-send-email-timur@freescale.com>

> For the 83xx, 85xx, and 86xx device trees, add a "local-mac-address" 
> property
> to every Ethernet node that didn't have one.  Add a comment indicating 
> that
> the "address" and/or "mac-address" properties are deprecated in DTS 
> files
> and will be removed at a later time.  Change all MAC address 
> properties to
> have a zero MAC address value.

Shouldn't you use the "??" notation instead, or is that
still not implemented?

Otherwise, looks good, ACK.

[I would have preferred if you had removed "address" right
away (replaced by "mac-address"), but since it is marked
for removal anyway, that's fine with me].


Segher

  reply	other threads:[~2007-06-23 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 19:33 [PATCH] powerpc: fix MAC address entries for 83xx, 85xx, and 86xx device trees Timur Tabi
2007-06-23 15:50 ` Segher Boessenkool [this message]
2007-06-25 12:50   ` Josh Boyer
2007-06-25 15:07   ` Timur Tabi
2007-06-25 15:46     ` Segher Boessenkool
2007-06-25 16:01       ` Timur Tabi
2007-06-26  7:40         ` Segher Boessenkool
2007-06-26 15:22           ` Timur Tabi
2007-06-26 15:42             ` Segher Boessenkool
2007-06-26 15:58               ` Timur Tabi
2007-06-25 16:19   ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70d005ce549921cc56481fe0b26faaa4@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).