From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: sambat goson <sombat3960@gmail.com>,
"Linuxppc-dev@lists.ozlabs.org" <Linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Geoff Levand <geoff@infradead.org>
Subject: Re: ps3_gelic_net.c issue (linux kernel 6.8-rc1)
Date: Thu, 25 Jan 2024 06:46:45 +0000 [thread overview]
Message-ID: <71205a49-86f7-48a7-94ce-cfd94e8b103d@csgroup.eu> (raw)
In-Reply-To: <CAC1vu61dspNPx7eVSsV1htnC0d+p4m3pzuv+9jQcyAFJEF4Y3w@mail.gmail.com>
Hi,
Le 24/01/2024 à 09:41, sambat goson a écrit :
>
> Hi,
> I've just test it and find below code not proper in function
> "gelic_descr_prepare_rx", line 398.
> it causes error as my attached file.
>
> descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size);
> if (!descr->skb) {
> descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */
> return -ENOMEM;
> }
> descr->hw_regs.dmac_cmd_status = 0;
> descr->hw_regs.result_size = 0;
> descr->hw_regs.valid_size = 0;
> descr->hw_regs.data_error = 0;
> descr->hw_regs.payload.dev_addr = 0;
> descr->hw_regs.payload.size = 0;
> descr->skb = NULL; ---->line 398
>
Looks like a copy/paste error from gelic_descr_release_tx() in commit
3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures"), the
whole block is wrong I guess, not only the descr->skb = NULL;
Geoff, can you fix it ?
Christophe
next prev parent reply other threads:[~2024-01-25 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 8:41 ps3_gelic_net.c issue (linux kernel 6.8-rc1) sambat goson
2024-01-25 6:46 ` Christophe Leroy [this message]
2024-01-25 6:56 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71205a49-86f7-48a7-94ce-cfd94e8b103d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Linuxppc-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sombat3960@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).