From: Naveen Naidu <naveennaidu479@gmail.com>
To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com
Cc: Naveen Naidu <naveennaidu479@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error()
Date: Mon, 4 Oct 2021 19:22:39 +0530 [thread overview]
Message-ID: <71cec6aef2535b48911bd98bd010012643eb0bd0.1633353468.git.naveennaidu479@gmail.com> (raw)
In-Reply-To: <cover.1633353468.git.naveennaidu479@gmail.com>
dpc_process_error() clears both AER fatal and non fatal status
registers. Instead of clearing each status registers via a different
function call use pci_aer_clear_status().
This helps clean up the code a bit.
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
---
drivers/pci/pcie/dpc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
index df3f3a10f8bc..faf4a1e77fab 100644
--- a/drivers/pci/pcie/dpc.c
+++ b/drivers/pci/pcie/dpc.c
@@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev)
dpc_get_aer_uncorrect_severity(pdev, &info) &&
aer_get_device_error_info(pdev, &info)) {
aer_print_error(pdev, &info);
- pci_aer_clear_nonfatal_status(pdev);
- pci_aer_clear_fatal_status(pdev);
+ pci_aer_clear_status(pdev);
}
}
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Naveen Naidu <naveennaidu479@gmail.com>
To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Naveen Naidu <naveennaidu479@gmail.com>,
skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error()
Date: Mon, 4 Oct 2021 19:36:30 +0530 [thread overview]
Message-ID: <71cec6aef2535b48911bd98bd010012643eb0bd0.1633353468.git.naveennaidu479@gmail.com> (raw)
Message-ID: <20211004140630.50sXzRQVH1C7mjCFZr-A719KucREYTnjYgqh2a3ycqA@z> (raw)
In-Reply-To: <cover.1633353468.git.naveennaidu479@gmail.com>
dpc_process_error() clears both AER fatal and non fatal status
registers. Instead of clearing each status registers via a different
function call use pci_aer_clear_status().
This helps clean up the code a bit.
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
---
drivers/pci/pcie/dpc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
index df3f3a10f8bc..faf4a1e77fab 100644
--- a/drivers/pci/pcie/dpc.c
+++ b/drivers/pci/pcie/dpc.c
@@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev)
dpc_get_aer_uncorrect_severity(pdev, &info) &&
aer_get_device_error_info(pdev, &info)) {
aer_print_error(pdev, &info);
- pci_aer_clear_nonfatal_status(pdev);
- pci_aer_clear_fatal_status(pdev);
+ pci_aer_clear_status(pdev);
}
}
--
2.25.1
next prev parent reply other threads:[~2021-10-04 22:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:52 [PATCH 0/8] Fix long standing AER Error Handling Issues Naveen Naidu
2021-10-04 13:52 ` [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 2/8] PCI: Cleanup struct aer_err_info Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` Naveen Naidu [this message]
2021-10-04 14:06 ` [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Naveen Naidu
2021-10-04 13:52 ` [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 " Naveen Naidu
2021-10-04 13:52 ` [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() Naveen Naidu
2021-10-04 14:06 ` Naveen Naidu
2021-10-04 14:12 ` [PATCH v2 " Naveen Naidu
2021-10-04 14:06 ` [PATCH v2 0/8] Fix long standing AER Error Handling Issues Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cec6aef2535b48911bd98bd010012643eb0bd0.1633353468.git.naveennaidu479@gmail.com \
--to=naveennaidu479@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).