From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34D79606A339 for ; Tue, 10 Nov 2026 15:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L39VbUrA Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jP94x5cwcz2yNj; Wed, 11 Nov 2026 02:08:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::631" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794323281; cv=none; b=SMQmpOZPnFs1GSo+q3JP0jjVs6sq53XLcLQ+352CzjA2mhmMjnXpSIzu8+KOLC45AyEjHydLF+yDif1o3zCobL0zArbHjFeUf52UvGjQ7WBiL0/3FKn1JeKgIhlj863VLS0Tq89lxo6hfjImyOSJl2l5M+TE5LUiOLWWforEgNTCyHPm15qAKAJzszBR05oO+Yyxo7PW+XK18MPuNYBSBxZUO/uWQpo7gsRuLLVdjqY94Qz94y8LtSdhtpRfRYvH3UUTPdMwl/o7/Nw3g9cq6WRaNh7upcXlIIpWdzBjQqy6Z6DhfVTxm2tVsEe+5YLkQlG8EBkTuZPjiHJPNYke5g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794323281; c=relaxed/relaxed; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YVOPBeZXY/DENV4eXdQaAbiLmS4AiS6YERrBJgliTx/hCQA4zUbJoNauJhcgCn6lZRDfwwNWTZslK3gh55hBxu7oMPwd5RS/5cTXYPT0QB7f1OSPMBfOJnwLZkedb+iXMv8LfHaNp4o5Ge2QZ6YytXOX0Q68HpFhRchvZ0iJrTZFI6W0J9scKu3qEeLHsfcecwHJD7PtE8VXUgfveQSQwKVUQtK4ueEOScUwjTxnZurbQkqSqTrpMH6cE9KrpBcL9FBbNxuE+x6meihlHc6qtK3Zvz6iRokn3XDHUgxP5bfM+kyF4/zx6xdPUC/FS+Bl905HKw06ds7KHhLHJsViLg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L39VbUrA; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::631; helo=mail-pl1-x631.google.com; envelope-from=kaylovefoss@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L39VbUrA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::631; helo=mail-pl1-x631.google.com; envelope-from=kaylovefoss@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jP94w23DYz2yDD for ; Wed, 11 Nov 2026 02:07:59 +1100 (AEDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2e8da6ef7ddso12775905ad.3 for ; Tue, 10 Nov 2026 07:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794323277; x=1794928077; darn=lists.ozlabs.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; b=L39VbUrA9zqmT6T2zklJgi/i9F+Y/3ly5eRJ9lKEeiLaisxriqyLgYYWTG5/EEdR7h 17gyYsbEt1q6vbbhmqG7tWeVGMehc7lwhEcRvEPpdgryeTgjeFO40jlnUSy6bl0gDz3m Tx6IR/1wUnwbKv9Ru+9MMerWh0s3eIjGa0qT+uXMxUOqxYTb9dRUIqYyZkCLM4NTKuph eepQWskjZnCpsL3UOBwPDjPYda+UPVD0diglSHUFPSkNhsfmKf1qB0i4ALGUAWMWbzp8 fi8lA3pst9QaKpMhYT9rAU36N9rrAq3ygMxbxG3NYeAh911bDZAiNufrN995wCGYXcIE UHNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794323277; x=1794928077; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; b=qTkMwLiFL6yQMYl0qWJ6xjWzX9vxyp32Y23gZ8wYp+D7UK5l9+p86otUpVjZW4dm2w uvPc/QlpFHx7cr+eRD/llxf0dYy8B4bF49BcBBTZn6+lnSQUmMr+yfXPEg7PF2SqZGWE v5kQOjMLlDfbzLNtWijQ3D3g9TmwKGqfg2T926AINEILlfuUT11+zFuouRg+XSDxlZAR VHvxtI79IImXNtQWczIliDPXbeNUfozpV5wBgrnTGGbtgrftlgNZBZ/qlRGGFNIJirqm Bck/cbK6QiSLjUa2kNetgGWDb/HmbzFj3K+qPVnpTrEne29/39c3cvPcs0QfLA9sImO7 dgcA== X-Forwarded-Encrypted: i=1; AL+hErFaNub/PW6YGDLldlRhzBXDCDngk5ZJ0ctS6nEM2ixBJpW2slmOUrThmZEk6zSdz/j1lnWmBpB6z1+6qgc=@lists.ozlabs.org X-Gm-Message-State: APuU4Z/H9xkyKmAXDR9SRWHAY11Rz85fGcFhXYPbpeoqarlGJVax3hSP cYi5tTb2/B/2fh2bUer2PDtGKQJRVY8tW4YwPwU833racqYHmFcdx5uR X-Gm-Gg: AYBFou0FzyzC++9aTzGXz/6DUJLWPh/7N8zIHId5d4+pdc3gMkuzKZJYoPHbdJRI/yW NbpxIJrc/nOayI8JPcfWwAfFxdhtrHo2UT6AqwE24yT7n1olIVeAetVOkiyiBZOiAOM9pTUhJVO lbeF+fnt0Q1B7FzvJwFdIfuk6Sd0aUa5/REjTCz/i2cdiX1s+4DbaLqV3x1B67BrsclEY6c2Be6 AKtRxZZvljEx+pb/9nct9Pq4S8SueI6eikD/LueAtrrrDReodx+p4691q0mmVaX+fCv3z+vlWt/ BW8NDZeFxLpjlielFYhBcUJV3ciI8GBv6pm2etQxXL/rTXgig4uycJDc+stM1onE/Up3XjgSEF/ ym1bTGLP+c9ahPMUlhGZtrveZT35mKnvNtjjL3Cad7z/G/sKp3k5hqc1t0lZBW3sAQ16EkV9IDT ctg1aMbCWBN4ejj+IhMk4eX6JHf1c/H8UnCBOTT2sZrKAphgjlSiY58ONGPH6gQYD1sG+e1Q3KA PygZ1gILveYg6f8gtwidTYN+cyXqQLyJembPFERFtRiGjCcjf1WEhhXpW6JVtk9I6+bM48BPEd2 31WZJcSISMNGPokSWulTQJQJxCBCEEL+T6bO8yes+SvEAO9KdZ+qIIvOf0+ZbvG3wbhjvaQ6UHk x7DppepRwpNo= X-Received: by 2002:a17:902:d481:b0:2ed:1ef3:9ec with SMTP id d9443c01a7336-2edb9172a2dmr26826345ad.14.1794323276968; Tue, 10 Nov 2026 07:07:56 -0800 (PST) Received: from [192.168.2.6] ([27.75.101.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2edb6d78dbcsm10397575ad.27.2026.11.10.07.07.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 07:07:56 -0800 (PST) Message-ID: <71f76e5e-ce24-4a71-863a-169ad262c510@gmail.com> Date: Tue, 10 Nov 2026 22:07:46 +0700 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 36/41] nvmet: refuse files on pseudo filesystems as namespace backing files To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-36-4c998976c6c7@kernel.org> Content-Language: en-US From: Bui Nguyen Nhu Quynh In-Reply-To: <20261110-work-loop-pseudo-v1-36-4c998976c6c7@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/10/2026 4:14 PM, Christian Brauner wrote: > The file backend takes any path that isn't a block device. With > buffered_io=1 that includes files on procfs or sysfs which then get read > and written by a kernel worker on behalf of the host. Refuse files on > pseudo filesystems just like loop does. > > Signed-off-by: Christian Brauner (Amutable) > --- > drivers/nvme/target/io-cmd-file.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c > index dfa8aa46188c..71c69bac5394 100644 > --- a/drivers/nvme/target/io-cmd-file.c > +++ b/drivers/nvme/target/io-cmd-file.c > @@ -52,6 +52,11 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) > goto err; > } > > + if (file_is_pseudo(ns->file)) { > + ret = -EINVAL; > + goto err; > + } > + > nvmet_file_ns_revalidate(ns); > > /* > I noticed patch 41/41 doesn't include a test for nvmet. Would it make sense to add one with buffered_io=1? The test would need a pseudo file that can be opened with O_RDWR and supports both read_iter and write_iter. Otherwise, it could pass without ever reaching the new file_is_pseudo() check. Thanks.