From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC8EC05027 for ; Fri, 20 Jan 2023 17:49:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Nz6SR6Q5Hz3fD8 for ; Sat, 21 Jan 2023 04:49:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm2 header.b=CQcLVRre; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=f3twNx4g; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=64.147.123.21; helo=wout5-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm2 header.b=CQcLVRre; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=f3twNx4g; dkim-atps=neutral Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Nz6RR0k7Gz3c8W for ; Sat, 21 Jan 2023 04:48:17 +1100 (AEDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id A46F43200A47; Fri, 20 Jan 2023 12:48:13 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 20 Jan 2023 12:48:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1674236892; x= 1674323292; bh=suuEDmGpMK8nFYB774MavCLSlHZ448gfBuVhNRXP7EU=; b=C QcLVRreBsT9rJUB1hoyVgUJ7vWGaM17ha5j9hXxIL5YJmaX14k1LJ4O4SbMkTXy1 2EAUuqM8XKqhhvsd2L0aLL8LCrKakXLnOJ4EDxHhkVa6MPdzzhgGAzS1Axale0lx N1IVM8igM6tDyqZOZmxJ0UcEaogD+K5Gtn3M8iTDM6Xrla1DTsc7K+AZSvmdZTPL w5OdBZ4a1MqQlaMaxhUbvAClZJu8DCf+O2DNcIRaFlcAVGz5HXxeqOL7JuTSr2qG PAhUDcC2sN3i2/tW4JwwmiCd6K3AgKYr2tHQy5Sr3ztdwW6Y41NEE6vGiyJR747R 1L2RKqasUqUfGfWTOy9Kg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674236892; x= 1674323292; bh=suuEDmGpMK8nFYB774MavCLSlHZ448gfBuVhNRXP7EU=; b=f 3twNx4gypSuyC82LNunQU3SUx3JQT35yk8KkrZhMH/pkfinaI/2/nBN3IKe0IUAW alB/7JBcG4PVMFUFBKYXCEObg7LPiNi4aCB/SXsaTj86L3b/Y+lkKJfyVPTVEzpu SzLhTYw+Iutd7v6MfVE1qr+ptyxCAiAZujfyEDDw4hMaffqHqL/spNpyOZlh/09y ZysYzJftXVhYmx+dZt8OqpVhZJeuHFNw6velxglhJeNRfovB6DRoCpEfdT2ZKLlI YAIiEtRbDevfm3mB9XjVABvjPBXeQmn7VcmkQPDpzrn5hVl1Ie3wBCyRA65RuAZu x3PYw5WILmzUoI62CMlLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudduvddguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgfekueelgeeigefhudduledtkeefffejueelheelfedutedttdfgveeu feefieegnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B9E9AB60086; Fri, 20 Jan 2023 12:48:11 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: <720a7d19-4b7f-4948-b044-c46a539a4b36@app.fastmail.com> In-Reply-To: References: <20221226123630.6515-1-pali@kernel.org> Date: Fri, 20 Jan 2023 18:47:52 +0100 From: "Arnd Bergmann" To: "Lee Jones" Subject: Re: [PATCH RESEND 0/8] Resend LED patches Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicholas Piggin , soc@kernel.org, Pavel Machek , =?UTF-8?Q?Pali_Roh=C3=A1r?= , linux-leds@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jan 20, 2023, at 18:15, Lee Jones wrote: > On Fri, 20 Jan 2023, Arnd Bergmann wrote: >> > Marek Beh=C3=BAn (3): >> > leds: turris-omnia: support HW controlled mode via private trigger >> > leds: turris-omnia: initialize multi-intensity to full >> > leds: turris-omnia: change max brightness from 255 to 1 >> > >> > Pali Roh=C3=A1r (5): >> > dt-bindings: leds: register-bit-led: Add active-low property >> > leds: syscon: Implement support for active-low property >> > powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board = CPL >> > Design >> > dt-bindings: leds: Add cznic,turris1x-leds.yaml binding >> > leds: Add support for Turris 1.x LEDs >> > >> > .../testing/sysfs-class-led-driver-turris1x | 31 ++ >> > .../bindings/leds/cznic,turris1x-leds.yaml | 118 +++++ >> > .../bindings/leds/register-bit-led.yaml | 5 + >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc.dtsi | 92 ++++ >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc_32b.dts | 6 +- >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc_36b.dts | 6 +- >> > arch/powerpc/boot/dts/fsl/p1020rdb-pd.dts | 44 +- >> > arch/powerpc/boot/dts/fsl/p1020utm-pc.dtsi | 37 ++ >> > arch/powerpc/boot/dts/fsl/p1020utm-pc_32b.dts | 4 +- >> > arch/powerpc/boot/dts/fsl/p1020utm-pc_36b.dts | 4 +- >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc.dtsi | 37 ++ >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc_32b.dts | 5 +- >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc_36b.dts | 5 +- >> > arch/powerpc/boot/dts/fsl/p2020rdb-pc.dtsi | 33 +- > >> > drivers/leds/Kconfig | 10 + >> > drivers/leds/Makefile | 1 + >> > drivers/leds/leds-syscon.c | 14 +- >> > drivers/leds/leds-turris-1x.c | 474 ++++++++++++++= ++++ >> > drivers/leds/leds-turris-omnia.c | 46 +- > > If everyone is convinced that applying these drivers is the correct > thing to do, I'd be happy to (rather) take them via LEDs. Ok, thanks. I had not actually looked at the patches until today. They were in the soc tree backlog but appeared to be misplaced there until I read the 0/10 message text. Looking at it now, I see: - patches 1 and 2 seem obvious and have been reviewed by others already - patch 3 is for arch/powerpc and should get merged through there if there are no objections to the binding in patch 4. - patch 5 is the big driver patch, with a Reviewed-by tag from Marek Beh=C3=BAn, who is the author of the last three patches. An earlier version of this patch was sent in June and got a few Acks and detailed feedback from Andy [1], but he's also not on Cc, and I don't know if his comments are all resolved in this version. - Patches 6, 7 and 8 all seem simple LED subsystem patches, they just need review from you in order to get applied. These are also missing a Signed-off-by from the submitter in addition to the author in order to be applied. =20 Arnd [1] https://lore.kernel.org/all/CAHp75Vcr6o2rm+T6Tr8sS4VXCLVHtmLPWy-njOK= AvO4AcZoW=3DA@mail.gmail.com/