From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF08AF01835 for ; Fri, 6 Mar 2026 13:26:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fS6cB0Rwvz2xqm; Sat, 07 Mar 2026 00:26:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772803561; cv=none; b=lWO9Zc2dqjlXmnHExNbnT7YrDKcRJWC1qf+v1cavAiaG9gXaYwzkGlskYC/UugxWhpRsELbB8RsHyVucpOzJuhH6Rq4tWwsnsNJ32cXXdlmSs0iesFaTywjJjE+btn5RTrVldZGOMm67P7gKjFAWK29UPFKuYvN8f7fEFerEMJjg6xhkGnCpEtfKmkNR9kvWenODUi+VD+3rGMJV6RZXIdB51hS0dm+KXDtv97b3sSd7yw+5ET5JMksrE4FZHuYcZtW6GbzKGf+OEHlZrVXr2R9cBUUPlFLhN9NFYVV9nSlhqrYF6PHwJmzxFZbfgnWACo2mzx9SdIJ31QvSQPWHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772803561; c=relaxed/relaxed; bh=7LFhEDz+8fbvJWmaugKgIjBYARs432xMAbsmDyA1By8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hr1WEtsL/dJ+PiaXJTqgLHy9bRMM1NoOLGCR8vSyRyCpDjiCv91QC1u4DESE6AFg+HxfODDV7dLJHiyT33euPq3cV10HObNXwAQ1eHJOyemH3jVKtus8oSwejmK2rWVD1L+iB84//omzWo3fYXUfF6XGBzpxxgkdVLA6oReTVVgamKAligs//44OYeCCFUsHYX3s6zzFIE3F0s5yAHrh9qQb+mag6W713ReSMz3Tx+A8R8lgpsiGd8CElpJFlUuxSSIfUF+qy7p8bO+sULQrvnPUK7xBLA6eZQTiYp8vlAZy/6DKEqMR8M6tp2U7T3wHmBpHde21r8lwdtPMbx4uCg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=V+rWmYyq; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=V+rWmYyq; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fS6c86MKqz2xT4 for ; Sat, 07 Mar 2026 00:26:00 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7418D60127; Fri, 6 Mar 2026 13:25:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2742DC2BC86; Fri, 6 Mar 2026 13:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772803558; bh=VU30iKH+h/qW7CEQKlKOIowLeYhmlgQ/q/0Y/mYCK3U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V+rWmYyqOSRcqABxv0QWdLshlJpYgu7fEwgb64B0fTA/c6pgG8MG/w+ZcKT0/BuWP PXHroR3YWS3vqI4BXdgO/PxHbkyiiDZx4CmTzeiMilwaV9zEePGKlT7F+TKuzNdFq6 v2AJAZCJG5oFbUGQE7dJAZb6p4yLwKqLyUPcFhQnI/04TmuuPHAC8Dlx12mvsL1UE+ 2la+iQcxibbkBOTCIH3s+84DEkiaAmThXEppa4VEG3WIhzOKk8/fe/f2f7DQvpp676 uLIpdNki57hG3MPr5ty1Pt4afb+h9Ntc6yYqShkM0PHnlXPALS6pVO+pdo3KeYSU62 7t2ssBVeagtzQ== Message-ID: <729e14d4-6949-4d46-9380-12331b5ad363@kernel.org> Date: Fri, 6 Mar 2026 14:25:51 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: move vma_kernel_pagesize() from hugetlb to mm.h To: "Lorenzo Stoakes (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Dan Williams References: <20260306101600.57355-1-david@kernel.org> <20260306101600.57355-2-david@kernel.org> <833950ef-e01d-4914-b5f9-bc1f6261b184@lucifer.local> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <833950ef-e01d-4914-b5f9-bc1f6261b184@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/26 12:07, Lorenzo Stoakes (Oracle) wrote: > On Fri, Mar 06, 2026 at 11:15:57AM +0100, David Hildenbrand (Arm) wrote: >> In the past, only hugetlb had special "vma_kernel_pagesize()" >> requirements, so it provided its own implementation. >> >> In commit 05ea88608d4e ("mm, hugetlbfs: introduce ->pagesize() to >> vm_operations_struct") we generalized that approach by providing a >> vm_ops->pagesize() callback to be used by device-dax. >> >> Once device-dax started using that callback in commit c1d53b92b95c >> ("device-dax: implement ->pagesize() for smaps to report MMUPageSize") >> it was missed that CONFIG_DEV_DAX does not depend on hugetlb support. >> >> So building a kernel with CONFIG_DEV_DAX but without CONFIG_HUGETLBFS >> would not pick up that value. >> >> Fix it by moving vma_kernel_pagesize() to mm.h, providing only a single >> implementation. While at it, improve the kerneldoc a bit. >> >> Ideally, we'd move vma_mmu_pagesize() as well to the header. However, >> its __weak symbol might be overwritten by a PPC variant in hugetlb code. >> So let's leave it in there for now, as it really only matters for some >> hugetlb oddities. >> >> This was found by code inspection. >> >> Fixes: c1d53b92b95c ("device-dax: implement ->pagesize() for smaps to report MMUPageSize") >> Cc: Dan Williams >> Signed-off-by: David Hildenbrand (Arm) > > LGTM, but you need to fix up VMA tests, I attach a patch below to do this. Will > this resolved: Thanks! I assume that should go into patch #2 instead? > > Reviewed-by: Lorenzo Stoakes (Oracle) [...] > --- > tools/testing/vma/include/dup.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/vma/include/dup.h b/tools/testing/vma/include/dup.h > index 3078ff1487d3..65b1030a7fdf 100644 > --- a/tools/testing/vma/include/dup.h > +++ b/tools/testing/vma/include/dup.h > @@ -1318,3 +1318,10 @@ static inline void vma_set_file(struct vm_area_struct *vma, struct file *file) > swap(vma->vm_file, file); > fput(file); > } > + > +static inline unsigned long vma_kernel_pagesize(struct vm_area_struct *vma) > +{ > + if (unlikely(vma->vm_ops && vma->vm_ops->pagesize)) > + return vma->vm_ops->pagesize(vma); > + return PAGE_SIZE; Should we just KIS and use PAGE_SIZE for the test? -- Cheers, David