From: Kumar Gala <galak@kernel.crashing.org>
To: "Pieter-Jan Busschaert" <pieterjan.busschaert@gmail.com>
Cc: "linuxppc-embedded@ozlabs.org \(\(\(\(E-Mail\)\)\)\)"
<linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 2.6.19] enable watchdog device on mpc834x platforms
Date: Thu, 14 Dec 2006 10:05:28 -0600 [thread overview]
Message-ID: <72D2A043-FCCB-4781-9764-1A398A611D0E@kernel.crashing.org> (raw)
In-Reply-To: <950a36fb0612140801x39de08c2gd3ad5ce9ba04f900@mail.gmail.com>
On Dec 14, 2006, at 10:01 AM, Pieter-Jan Busschaert wrote:
>> Two things about this patch:
>> 1. We've actively avoid taking non-bug fix patches to arch/ppc as we
>> try to move people over to arch/powerpc.
>> 2. You can't hard code freq in the platform data like that. It's
>> expected to be the bus frequency the device is running at.
>
> The frequency is only used once in the driver to printk the
> watchdog-timeout in seconds. It doesn't affect the functionallity in
> any way. I looked at ways to get the cpu frequency dynamically in
> there, but didn't find a simple way to do it.
It does, in that the drive reports it on a WDIOC_GETTIMEOUT to user
space. (See how we use timeout_sec).
> But, because of your first comment, I suppose this patch will never
> enter the linux kernel, even if I get the frequency dynamically?
Most likely, but its still good to have the patches on the list for
people to pull if they need them.
- k
prev parent reply other threads:[~2006-12-14 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 10:41 [PATCH 2.6.19] enable watchdog device on mpc834x platforms Pieter-Jan Busschaert
2006-12-14 15:41 ` Kumar Gala
[not found] ` <950a36fb0612140801x39de08c2gd3ad5ce9ba04f900@mail.gmail.com>
2006-12-14 16:05 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72D2A043-FCCB-4781-9764-1A398A611D0E@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=pieterjan.busschaert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox