[PATCH] powerpc: Remove some redunant isync instructions

[PATCH] powerpc: Remove some redunant isync instructions

[MOKUNO Masakazu]

Remove some redundant isync instructions.

enable_64b_mode() already does an isync, so there is no need to do it again.

Signed-off-by: MOKUNO, Masakazu <mokuno@sm.sony.co.jp>

---
 arch/powerpc/kernel/head_64.S |    2 --
 1 files changed, 2 deletions(-)

--- ps3-linux-dev.orig/arch/powerpc/kernel/head_64.S
+++ ps3-linux-dev/arch/powerpc/kernel/head_64.S
@@ -1555,7 +1555,6 @@ _GLOBAL(generic_secondary_smp_init)
 	
 	/* turn on 64-bit mode */
 	bl	.enable_64b_mode
-	isync
 
 	/* Set up a paca value for this processor. Since we have the
 	 * physical cpu id in r24, we need to search the pacas to find
@@ -1851,7 +1850,6 @@ __secondary_start_pmac_0:
 _GLOBAL(pmac_secondary_start)
 	/* turn on 64-bit mode */
 	bl	.enable_64b_mode
-	isync
 
 	/* Copy some CPU settings from CPU 0 */
 	bl	.__restore_cpu_ppc970

--
Masakazu MOKUNO

Re: [PATCH] powerpc: Remove some redunant isync instructions

[Segher Boessenkool]

> Remove some redundant isync instructions.
>
> enable_64b_mode() already does an isync, so there is no need to do it 
> again.
>
> Signed-off-by: MOKUNO, Masakazu <mokuno@sm.sony.co.jp>

Looks good to me...


Segher

Re: [PATCH] powerpc: Remove some redunant isync instructions

[Benjamin Herrenschmidt]

On Mon, 2007-02-26 at 17:21 +0900, MOKUNO Masakazu wrote:
> Remove some redundant isync instructions.
> 
> enable_64b_mode() already does an isync, so there is no need to do it again.
> 
> Signed-off-by: MOKUNO, Masakazu <mokuno@sm.sony.co.jp>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  arch/powerpc/kernel/head_64.S |    2 --
>  1 files changed, 2 deletions(-)
> 
> --- ps3-linux-dev.orig/arch/powerpc/kernel/head_64.S
> +++ ps3-linux-dev/arch/powerpc/kernel/head_64.S
> @@ -1555,7 +1555,6 @@ _GLOBAL(generic_secondary_smp_init)
>  	
>  	/* turn on 64-bit mode */
>  	bl	.enable_64b_mode
> -	isync
>  
>  	/* Set up a paca value for this processor. Since we have the
>  	 * physical cpu id in r24, we need to search the pacas to find
> @@ -1851,7 +1850,6 @@ __secondary_start_pmac_0:
>  _GLOBAL(pmac_secondary_start)
>  	/* turn on 64-bit mode */
>  	bl	.enable_64b_mode
> -	isync
>  
>  	/* Copy some CPU settings from CPU 0 */
>  	bl	.__restore_cpu_ppc970
> 
> --
> Masakazu MOKUNO
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev