From: Kumar Gala <galak@kernel.crashing.org>
To: David Brownell <david-b@pacbell.net>
Cc: linuxppc-dev@ozlabs.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [PATCH] OHCI: add PowerPC 440EP/440EPx support
Date: Mon, 8 Oct 2007 12:39:34 -0500 [thread overview]
Message-ID: <7363E251-62FF-4574-9FF7-8E5719012BAD@kernel.crashing.org> (raw)
In-Reply-To: <20071008161927.84C601915AE@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
On Oct 8, 2007, at 11:19 AM, David Brownell wrote:
>>> Near as I can tell, the original code is wrong ... the hcca-
>>> >frame_no
>>> byte offset is fully specified, so that shift should always be 16.
>>
>> Are you saying that it should always be #define
>> OHCI_BE_FRAME_NO_SHIFT
>> 16 for big endian platforms?
>
> More than that, I'm saying that shouldn't even be a #define! The
> default should be that drivers expect chips to follow the interface
> specs. Any value other than 16 violates the OHCI spec.
>
> However, based on one other post, I suspect at least one Freescale
> part will need to declare a chip quirk for this case.
Which Freescale part do you think needs this?
- k
next prev parent reply other threads:[~2007-10-08 17:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 14:25 [PATCH] OHCI: add PowerPC 440EP/440EPx support Valentine Barshak
2007-10-08 15:01 ` [linux-usb-devel] " David Brownell
2007-10-08 16:06 ` Valentine Barshak
2007-10-08 16:19 ` David Brownell
2007-10-08 16:54 ` [PATCH] USB: Add frame_no big endian OHCI quirk Valentine Barshak
2007-10-08 16:58 ` [linux-usb-devel] " Valentine Barshak
2007-10-08 18:41 ` Valentine Barshak
2007-10-08 18:52 ` [linux-usb-devel] " Dale Farnsworth
2007-10-08 17:39 ` Kumar Gala [this message]
2007-10-08 17:42 ` [linux-usb-devel] [PATCH] OHCI: add PowerPC 440EP/440EPx support Valentine Barshak
2007-10-08 19:45 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7363E251-62FF-4574-9FF7-8E5719012BAD@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox