From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 022FDF3C266 for ; Mon, 9 Mar 2026 13:46:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fTywm2QJnz309P; Tue, 10 Mar 2026 00:46:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773064008; cv=none; b=DZdo1gDSUGbobcHe08OhyE23umjdClaeUDXMUEkvJptQfC4Ua2X4qL7pKq7KaLMGEbvmfoQaGzzA92ZDchS66HfL5uOlLTcE8Ex3pBAeI2/5oJOmo0+eeiVNdx+PLr/4mmgklZiYBYyNnfQQrHi4xCQXVTGkjpnKSQlSnXDXtbXS6TuFXshwZNTwpP03i8UeVf8x2AEgXkJoPswgBiSqlmCrRBOZrEQzMiOiPMF+VwysRCaqFhgo4tZXvTlTwpoo4Rjqbb2xd+hFHZQVQtksebUckvhedMLN0me0+sgTqKLl85qQ94DeQ6wjqsM0hck0kXyLUlGxLOj0e01Mi36JlA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773064008; c=relaxed/relaxed; bh=zso1UHrl7gDNYxkrQKsLxt0cUGSVikyYTIXnkhMmBCE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hMoYvcW5TDy+zsk6re0EQMv+GYb20DvmM5RaTRoqh7fRXiGdCdEPByH/YZU7dQ+sjdHlwIFT4DM9iX6la3JBceOesNfXzPHSJWFZXrVf1mIZ2jCqRCO/ERZwYZfGeJvZLwBsD5+qfPbA6HsBGt9C5XdDM+5FySDKoK6r5CcBRKVd4xWIkD/peuf/KSQYTGe//kSqH3JXIthqthtURKE44FSNdm6VPX3I1xaBNQCTlJ9VUBx1qfVZJE0H2LHJgb7QIVc4gGJve5fzOiSDH7/jF0iehb9LEPYmoUv6MoI8xP92GRjSmeVteaFmxoLqsDSg6cxUOtxHXpcXz4LwU1wnrg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BVr69GD8; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BVr69GD8; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fTywl2zn6z2ySb for ; Tue, 10 Mar 2026 00:46:47 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 77C214423B; Mon, 9 Mar 2026 13:46:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF8FC4CEF7; Mon, 9 Mar 2026 13:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773064005; bh=w0QUYZum+m+R/ZMJD9ICvWbnwxxvrz4NQJRGvdgYc+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BVr69GD85TMcTAfG+a8utDGbnLRZpnfsgk6oAEieKIf3SbpafBvF3+irOxH5364Mf 5pQjiP3OB9FC6sxDF6sRahqD3JxDLeM/LKZhytQKKexcd9nKBgdJPKEyw8sk8hmBqZ 6Umeng6LJPjNhP9ijAtZ1GLP3fQirKriMZIBcjz1MV/Ly4Ym8+L+fbakf0sGYzf2HZ 3zIBqoZorFxzO8i8L6kszr5AnLvTpWYNSPn5PmXLkOowtVs0WINaH4TFDGQhbj2jWW Xu+fRiMPtxXfm3CsyrGqKEUJHR4HPp+HrebcbqvJ0J7zXXW7tbIaDGtBQ28EmTK0dV febooG99fQKig== Date: Mon, 9 Mar 2026 13:46:27 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 11/16] mm/memory: inline unmap_page_range() into __zap_vma_range() Message-ID: <737a88b8-8221-44e6-aa90-3be326bc8612@lucifer.local> References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-12-david@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 06, 2026 at 02:16:26PM +0100, David Hildenbrand (Arm) wrote: > On 3/6/26 13:29, Lorenzo Stoakes (Oracle) wrote: > > On Fri, Feb 27, 2026 at 09:08:42PM +0100, David Hildenbrand (Arm) wrote: > >> Let's inline it into the single caller to reduce the number of confusing > >> unmap/zap helpers. > >> > >> Get rid of the unnecessary BUG_ON(). > >> > >> Signed-off-by: David Hildenbrand (Arm) > > > > Small nits below, but overall LGTM so: > > > > Reviewed-by: Lorenzo Stoakes (Oracle) > > > >> --- > >> mm/memory.c | 32 ++++++++++++-------------------- > >> 1 file changed, 12 insertions(+), 20 deletions(-) > >> > >> diff --git a/mm/memory.c b/mm/memory.c > >> index 394b2e931974..1c0bcdfc73b7 100644 > >> --- a/mm/memory.c > >> +++ b/mm/memory.c > >> @@ -2056,25 +2056,6 @@ static inline unsigned long zap_p4d_range(struct mmu_gather *tlb, > >> return addr; > >> } > >> > >> -static void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > >> - unsigned long addr, unsigned long end, > >> - struct zap_details *details) > >> -{ > >> - pgd_t *pgd; > >> - unsigned long next; > >> - > >> - BUG_ON(addr >= end); > >> - tlb_start_vma(tlb, vma); > >> - pgd = pgd_offset(vma->vm_mm, addr); > >> - do { > >> - next = pgd_addr_end(addr, end); > >> - if (pgd_none_or_clear_bad(pgd)) > >> - continue; > >> - next = zap_p4d_range(tlb, vma, pgd, addr, next, details); > >> - } while (pgd++, addr = next, addr != end); > >> - tlb_end_vma(tlb, vma); > >> -} > >> - > >> static void __zap_vma_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > >> unsigned long start, unsigned long end, > >> struct zap_details *details) > >> @@ -2100,7 +2081,18 @@ static void __zap_vma_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > >> return; > >> __unmap_hugepage_range(tlb, vma, start, end, NULL, zap_flags); > >> } else { > >> - unmap_page_range(tlb, vma, start, end, details); > >> + unsigned long next, cur = start; > > > > VERY nitty, but generally current is abbreviated to curr not cur. > > > > The following might not be fully expressive (but simple to grep): > > $ git grep "cur_" | wc -l > 24261 > $ git grep "curr_" | wc -l > 9288 Lol hmm... > > Tells me that "cur" is rather common. > > > It's not a big deal, but why not addr? > > Good question, I can just do that. :) Thanks! > > -- > Cheers, > > David Cheers, Lorenzo