From: Balbir Singh <bsingharora@gmail.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: kvm-ppc@vger.kernel.org, warrier@linux.vnet.ibm.com, mpe@ellerman.id.au
Subject: Re: [PATCH] powerpc/kvm: Fix build error on book3s_hv.c
Date: Wed, 11 May 2016 15:01:40 +1000 [thread overview]
Message-ID: <73cbb393-f48f-735e-6d23-fd2366bf376a@gmail.com> (raw)
In-Reply-To: <1462929355-30681-1-git-send-email-gwshan@linux.vnet.ibm.com>
On 11/05/16 11:15, Gavin Shan wrote:
> When CONFIG_KVM_XICS is enabled, CPU_UP_PREPARE and other macros for
> CPU states in linux/cpu.h are needed by arch/powerpc/kvm/book3s_hv.c.
> Otherwise, build error as below is seen:
>
> gwshan@gwshan:~/sandbox/l$ make arch/powerpc/kvm/book3s_hv.o
> :
> CC arch/powerpc/kvm/book3s_hv.o
> arch/powerpc/kvm/book3s_hv.c: In function ‘kvmppc_cpu_notify’:
> arch/powerpc/kvm/book3s_hv.c:3072:7: error: ‘CPU_UP_PREPARE’ \
> undeclared (first use in this function)
>
> This fixes the issue introduced by commit <6f3bb80944> ("KVM: PPC:
> Book3S HV: kvmppc_host_rm_ops - handle offlining CPUs").
>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> ---
I ran into the same thing, fixed it, but forgot to send it out
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
next prev parent reply other threads:[~2016-05-11 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 1:15 [PATCH] powerpc/kvm: Fix build error on book3s_hv.c Gavin Shan
2016-05-11 5:01 ` Balbir Singh [this message]
2016-05-11 11:38 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73cbb393-f48f-735e-6d23-fd2366bf376a@gmail.com \
--to=bsingharora@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=warrier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).