linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>,
	Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
	Suraj Jitindar Singh <sjitindarsingh@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware
Date: Tue, 04 Jun 2019 10:18:12 +1000	[thread overview]
Message-ID: <73f8650b2bcb861d79cad675d6c8e1b92f4d4d11.camel@kernel.crashing.org> (raw)
In-Reply-To: <20190603234247.GQ31586@gate.crashing.org>

On Mon, 2019-06-03 at 18:42 -0500, Segher Boessenkool wrote:
> Hi!
> 
> On Mon, Jun 03, 2019 at 12:56:26PM +1000, Alexey Kardashevskiy wrote:
> > On 03/06/2019 09:23, Segher Boessenkool wrote:
> > > > So I go for the simple one and agree with Alexey's idea.
> > > 
> > > When dealing with a whole device tree you have to know about the
> > > various
> > > dynamically generated nodes and props, and handle each
> > > appropriately.
> > 
> > The code I am changing fetches the device tree and build an fdt.
> > What is
> > that special knowledge in this context you are talking about?
> 
> Things like /options are dynamically generated.

They are generated before we do the call to extract the fdt, what's the
problem there ?

> I thought you would just be able to reuse some FDT parsing code to
> implement my suggested new interface.  Maybe that was too optimistic.

No, the idea is to have SLOF re-flatten it's live tree and hand us a
blob. At least that's my understanding.

Ben.



  reply	other threads:[~2019-06-04  0:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  3:42 [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware Alexey Kardashevskiy
2019-05-02  4:27 ` David Gibson
2019-05-03  0:10   ` Stewart Smith
2019-05-03  2:35     ` David Gibson
2019-05-06  2:21       ` Alexey Kardashevskiy
2019-05-03 15:35     ` Segher Boessenkool
2019-05-03 15:32 ` Segher Boessenkool
2019-05-30  7:09 ` Alexey Kardashevskiy
2019-05-30 19:37   ` Segher Boessenkool
2019-05-31  1:03     ` Benjamin Herrenschmidt
2019-06-02 23:23       ` Segher Boessenkool
2019-06-03  2:56         ` Alexey Kardashevskiy
2019-06-03 21:18           ` Benjamin Herrenschmidt
2019-06-03 23:49             ` Segher Boessenkool
2019-06-04  0:32               ` David Gibson
2019-06-03 23:42           ` Segher Boessenkool
2019-06-04  0:18             ` Benjamin Herrenschmidt [this message]
2019-06-04  5:00             ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73f8650b2bcb861d79cad675d6c8e1b92f4d4d11.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=segher@kernel.crashing.org \
    --cc=sjitindarsingh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).