From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: References: <20070912031132.GC20218@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <75C5D3E1-F5E0-4DB6-B9E6-9FC6B3013485@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH v3] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port Date: Wed, 12 Sep 2007 22:27:42 -0500 To: Segher Boessenkool Cc: linuxppc-dev@ozlabs.org, David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sep 12, 2007, at 9:10 AM, Segher Boessenkool wrote: >>>> + i8259: interrupt-controller@20 { >>>> + reg = <1 20 2 >>>> + 1 a0 2 >>>> + 1 4d0 2>; >>>> + clock-frequency = <0>; >>> >>> Hrm.. what is clock-frequency for on an i8259? I see that other >>> 8259 >>> descriptions have this as well, so it's not a problem with this >>> patch >>> specifically. >> >> Its a copy-paste thing so I don't know. > > If your bootwrapper doesn't fill in this value, you should get rid > of this property -- better to have no value than to have the wrong > value, esp. since it's probably unused anyway. I'm going to kill this since I can't find it spec'd anywhere. - k