From: Kumar Gala <galak@kernel.crashing.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linuxppc-dev@ozlabs.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: talitos - Fix modpost warning
Date: Wed, 3 Dec 2008 08:52:29 -0600 [thread overview]
Message-ID: <75DC3D14-4019-4C55-A553-C54063790DD8@kernel.crashing.org> (raw)
In-Reply-To: <20081203120640.GB9818@gondor.apana.org.au>
On Dec 3, 2008, at 6:06 AM, Herbert Xu wrote:
> On Tue, Dec 02, 2008 at 10:29:16PM -0600, Kumar Gala wrote:
>> Removed __devexit from talitos_remove() since its also called from
>> talitos_probe().
>>
>> WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference
>> from the function talitos_probe() to the
>> function .devexit.text:talitos_remove()
>> The function talitos_probe() references a function in an exit
>> section.
>> Often the function talitos_remove() has valid usage outside the
>> exit section
>> and the fix is to remove the __devexit annotation of talitos_remove.
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> OK, but what about the __devexit_p reference on talitos_remove?
> We should remove that too.
missed that one. will fix up and post a new patch.
- k
next prev parent reply other threads:[~2008-12-03 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 4:29 [PATCH] crypto: talitos - Fix modpost warning Kumar Gala
2008-12-03 12:06 ` Herbert Xu
2008-12-03 14:52 ` Kumar Gala [this message]
2008-12-03 15:36 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75DC3D14-4019-4C55-A553-C54063790DD8@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).