From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A39DEB64D9 for ; Thu, 15 Jun 2023 16:35:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L4eXqxXs; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qhnw95D6Kz3brV for ; Fri, 16 Jun 2023 02:35:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L4eXqxXs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=rdunlap@infradead.org; receiver=lists.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QhnvC0VKbz2xq8 for ; Fri, 16 Jun 2023 02:34:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=d9r3JB7tEgccA9qtOtOzXsHyll/xLx6MaKfk6VCI57g=; b=L4eXqxXs2JfQVvn2sh7BCzfwgR egPwVF6LvzR/evxffYcnndfXRlfz2iXwNYdSqCPkAO0NEC5xaJ23lr3IQDc5dPD1+cMpucKSRHZQw yoyW805HEpmxeLaLIqTtEv1/FcNgXDMDRnbQ4+fmIS20Kn2lvqq5aBvmfPHsx/PI3X1XrdLKxF0fc aL3tI6aqbgXOgTUzdYph8bDDvgMpIO1CxU99ESSzOibK9jIwcjoTd+eG+oj3wt72E1GaCc71gPaMG xcXAchM+K9RkqE/s2TB9kdF7IwnvNolChK25lJ5GfMBBb+3LkkDxpIw/kTkuVlKQZSG17/iXlSy7+ LXsrOHyg==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q9pvj-00FRqd-2S; Thu, 15 Jun 2023 16:34:39 +0000 Message-ID: <75a27ada-7e88-2f93-48ee-3dc89b7f1a9a@infradead.org> Date: Thu, 15 Jun 2023 09:34:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Content-Language: en-US From: Randy Dunlap To: Timothy Pearson References: <20230602140143.0af52cee@canb.auug.org.au> <2d188c87-ef34-3812-7330-a985f756d959@infradead.org> <87h6rogjok.fsf@mail.lhotse> <586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com> <373175504.6295209.1686845130893.JavaMail.zimbra@raptorengineeringinc.com> <208f3734-4902-ff5c-3410-5b9cd984dad7@infradead.org> In-Reply-To: <208f3734-4902-ff5c-3410-5b9cd984dad7@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Alexey Kardashevskiy , linux-kernel , Linux Next Mailing List , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/15/23 09:13, Randy Dunlap wrote: > > > On 6/15/23 09:05, Timothy Pearson wrote: >> >> >> ----- Original Message ----- >>> From: "Randy Dunlap" >>> To: "Timothy Pearson" , "Michael Ellerman" >>> Cc: "Stephen Rothwell" , "Linux Next Mailing List" , "linux-kernel" >>> , "linuxppc-dev" , "Alexey Kardashevskiy" >>> Sent: Thursday, June 15, 2023 11:00:08 AM >>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) >> >>> Hi Timothy, >>> >>> On 6/3/23 20:57, Timothy Pearson wrote: >>>> >>>> >>>> ----- Original Message ----- >>>>> From: "Michael Ellerman" >>>>> To: "Randy Dunlap" , "Stephen Rothwell" >>>>> , "Linux Next Mailing List" >>>>> >>>>> Cc: "linux-kernel" , "linuxppc-dev" >>>>> , "Alexey >>>>> Kardashevskiy" , "Timothy Pearson" >>>>> >>>>> Sent: Saturday, June 3, 2023 7:22:51 PM >>>>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) >>>> >>>>> Randy Dunlap writes: >>>>>> On 6/1/23 21:01, Stephen Rothwell wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> Changes since 20230601: >>>>>>> >>>>>> >>>>>> On powerpc64, a randconfig failed with: >>>>>> >>>>>> In file included from ../include/linux/list.h:5, >>>>>> from ../include/linux/preempt.h:11, >>>>>> from ../include/linux/spinlock.h:56, >>>>>> from ../include/linux/mmzone.h:8, >>>>>> from ../include/linux/gfp.h:7, >>>>>> from ../include/linux/slab.h:15, >>>>>> from ../arch/powerpc/kernel/iommu.c:15: >>>>>> ../arch/powerpc/kernel/iommu.c: In function >>>>>> 'spapr_tce_setup_phb_iommus_initcall': >>>>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use >>>>>> in this function); did you mean 'zonelist'? >>>>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) { >>>>>> | ^~~~~~~~~ >>>>> ... >>>>> >>>>> hose_list is in pci-common.c which is built when PCI=y. >>>>> >>>>> PSERIES and POWERNV force PCI=y. >>>>> >>>>> But this config has neither: >>>>> >>>>> # CONFIG_PPC_POWERNV is not set >>>>> # CONFIG_PPC_PSERIES is not set >>>>> CONFIG_HAVE_PCI=y >>>>> # CONFIG_PCI is not set >>>>> # CONFIG_COMMON_CLK_RS9_PCIE is not set >>>>> >>>>> >>>>> Probably the spapr_tce code should be wrapped in an #ifdef that is only >>>>> enabled when POWERNV || PSERIES is enabled. >>>>> >>>>> cheers >>>> >>>> Sounds reasonable, I was going to look into this further over the weekend. I >>>> can put together a patch for Monday if that works? >>> >>> Did you prepare a patch for this? I am still seeing this build error. >>> >>> thanks. >>> -- >>> ~Randy >> >> Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive? > > I don't know - I'm not subscribed to that list. > > It's probably still in the patchworks review cycle > so it hasn't been applied anywhere that gets into linux-next. OK, it's here, mark with Success: http://patchwork.ozlabs.org/project/linuxppc-dev/patch/2015925968.3546872.1685990936823.JavaMail.zimbra@raptorengineeringinc.com/ I don't know what happens to it next or when. thanks. -- ~Randy