From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4EDFC43334 for ; Wed, 29 Jun 2022 07:38:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LXtbt3hrHz3drJ for ; Wed, 29 Jun 2022 17:38:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LqaQQ4rM; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LqaQQ4rM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=javierm@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LqaQQ4rM; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LqaQQ4rM; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LXtb357Y5z3bq3 for ; Wed, 29 Jun 2022 17:37:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656488234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1h0smKgkaQYyMckjg1gEO+92UXCJgyf7f6YfzsCAFg4=; b=LqaQQ4rMNNaHAgwNqe1aoCTG75kn7/oNsqAIKCxO5hJyIk+F/Yw45XvOyYaLbryYdHBzdJ 7bhG0i7WnNZRvAnFxgrRWBJIR3H02XwQGwDE9mvpMwd1ztR1wRLQMBek1iG7s251Msv7kc IxwAvqSKWZ18XPybTGnZsn34pvCYHnQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656488234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1h0smKgkaQYyMckjg1gEO+92UXCJgyf7f6YfzsCAFg4=; b=LqaQQ4rMNNaHAgwNqe1aoCTG75kn7/oNsqAIKCxO5hJyIk+F/Yw45XvOyYaLbryYdHBzdJ 7bhG0i7WnNZRvAnFxgrRWBJIR3H02XwQGwDE9mvpMwd1ztR1wRLQMBek1iG7s251Msv7kc IxwAvqSKWZ18XPybTGnZsn34pvCYHnQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-126-PkOu5gN4NO62cJlFVK1SNQ-1; Wed, 29 Jun 2022 03:37:12 -0400 X-MC-Unique: PkOu5gN4NO62cJlFVK1SNQ-1 Received: by mail-wr1-f69.google.com with SMTP id y18-20020adfdf12000000b0021b94ba4c37so2159783wrl.11 for ; Wed, 29 Jun 2022 00:37:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1h0smKgkaQYyMckjg1gEO+92UXCJgyf7f6YfzsCAFg4=; b=nuMmPQy4myrkInhrjMaJ1GhvT5qCu+J/5dyEXfHPSZ1Npu5nFN9bEyFDstVPmVl+/a eZcNBxkN/GqLOIa8IWeMRHCTwkdjd6eczlv6/rpEFg/aaD1WRAWkI+3G0mMCBOXpFlkb qGjjBgvgAEKNDeCS5qKBkAWF8hLIbKF8JCSSeswqs8V0TA9CvgsIFArgrZfGySp0klFl AAF7xdtfnvA24M7VglmYIUiPyOpmo5AdwSUcvMZm7/ykUhGHg/ZQp/z4l4kOWQWuzUjA xJ5S6aod77d57+6sKRFP+hhXpcaWKWBoxW5j+lIH5+dKGlgNcCTbEJYKWxjEdxNq971d R0Eg== X-Gm-Message-State: AJIora/uoCpXnIW7mUP3j2OxbYpdlNj4KZHU3ROgmSfm6EBMbGhmwyGZ QIzsv475lMglBhJ3WESQC5ur02aSPggBUaQJExmiGzgBp8V9a2xvXfVbr9XdazzVU9XwLfnAHWV ZIt0bBfuDVmvGCJutrhOxq2H+1Q== X-Received: by 2002:a05:6000:1448:b0:21b:b7db:c40b with SMTP id v8-20020a056000144800b0021bb7dbc40bmr1650263wrx.279.1656488230979; Wed, 29 Jun 2022 00:37:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vfq7mqFRSJqFJPQOP6rs25Ch1nA7fBeueZwuaRaLaWENw0ay54yTOP4QHXmGLo1NEA4L9c5g== X-Received: by 2002:a05:6000:1448:b0:21b:b7db:c40b with SMTP id v8-20020a056000144800b0021bb7dbc40bmr1650238wrx.279.1656488230741; Wed, 29 Jun 2022 00:37:10 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id j10-20020a5d448a000000b0021b8c99860asm15832366wrq.115.2022.06.29.00.37.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 00:37:10 -0700 (PDT) Message-ID: <7654a74e-a410-a8a5-c228-d006dbbc200f@redhat.com> Date: Wed, 29 Jun 2022 09:37:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 6/6] i2c: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jeremy Kerr References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <60cc6796236f23c028a9ae76dbe00d1917df82a5.camel@codeconstruct.com.au> <20220629072304.qazmloqdi5h5kdre@pengutronix.de> From: Javier Martinez Canillas In-Reply-To: <20220629072304.qazmloqdi5h5kdre@pengutronix.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, patches@opensource.cirrus.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev, linux-staging@lists.linux.dev, kasan-dev@googlegroups.com, Broadcom internal kernel review list , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Support Opensource , Greg Kroah-Hartman , Wolfram Sang , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , netdev@vger.kernel.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/29/22 09:23, Uwe Kleine-König wrote: > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] > Yes, it also bounced for me when I tried to reply earlier today. > diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c b/drivers/gpu/drm/solomon/ssd130x-i2c.c > index 1e0fcec7be47..ddfa0bb5d9c9 100644 > --- a/drivers/gpu/drm/solomon/ssd130x-i2c.c > +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c > @@ -39,13 +39,11 @@ static int ssd130x_i2c_probe(struct i2c_client *client) > return 0; > } > > -static int ssd130x_i2c_remove(struct i2c_client *client) > +static void ssd130x_i2c_remove(struct i2c_client *client) > { > struct ssd130x_device *ssd130x = i2c_get_clientdata(client); > > ssd130x_remove(ssd130x); > - > - return 0; > } > > static void ssd130x_i2c_shutdown(struct i2c_client *client) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat