From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Michael Neuling To: Aruna Balakrishnaiah Subject: Re: [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig In-reply-to: <20130621083639.4039.27789.stgit@aruna-ThinkPad-T420> References: <20130621083639.4039.27789.stgit@aruna-ThinkPad-T420> Date: Mon, 24 Jun 2013 11:21:36 +1000 Message-ID: <7684.1372036896@ale.ozlabs.ibm.com> Cc: mahesh@linux.vnet.ibm.com, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Enable PSTORE in pseries_defconfig Please add a "why" to your changelogs eg. "Now we have pstore support for nvram on pseries, enable it in the default config" "Why" you are changing something is more important than "what", since you can always determine "what" is being changed, by looking at the diff. The "why" will be long forgotten. > > Signed-off-by: Aruna Balakrishnaiah > --- > arch/powerpc/configs/pseries_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig > index c4dfbaf..9630a50 100644 > --- a/arch/powerpc/configs/pseries_defconfig > +++ b/arch/powerpc/configs/pseries_defconfig > @@ -347,3 +347,4 @@ CONFIG_VIRTUALIZATION=y > CONFIG_KVM_BOOK3S_64=m > CONFIG_KVM_BOOK3S_64_HV=y > CONFIG_VHOST_NET=m > +CONFIG_PSTORE=y This should really be added in the right location on the config, not just at the end. ie. @@ -296,6 +293,7 @@ CONFIG_SQUASHFS_XATTR=y CONFIG_SQUASHFS_LZO=y CONFIG_SQUASHFS_XZ=y +CONFIG_PSTORE=y CONFIG_NFS_FS=y CONFIG_NFS_V3_ACL=y CONFIG_NFS_V4=y