From: Segher Boessenkool <segher@kernel.crashing.org>
To: Manish Ahuja <ahuja@austin.ibm.com>
Cc: Olof Johansson <olof@lixom.net>,
mahuja@us.ibm.com, linasvepstas@gmail.com, paulus@samba.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] pseries: phyp dump: Variable size reserve space.
Date: Wed, 9 Apr 2008 21:39:59 +0200 [thread overview]
Message-ID: <76b6f0069fd6d80f69620e39c8528e9d@kernel.crashing.org> (raw)
In-Reply-To: <47FCFDA4.10709@austin.ibm.com>
>>> + tmp = tmp & ~0x000000001FFFFFFF;
Note that this only works as you expect because the constant is
signed here -- the extra zeroes do not magically make it a 64-bit
number. So it goes 32-bit 0x1fffffff -> 32-bit -0x20000000 ->
64-bit -0x20000000.
Please consider writing it with an "L" suffix, or "UL" even, to
reduce trickiness and surprises if ever that number is changed.
Segher
next prev parent reply other threads:[~2008-04-09 19:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 23:45 [PATCH] pseries: phyp dump: Variable size reserve space Manish Ahuja
2008-04-08 2:43 ` Olof Johansson
2008-04-09 17:32 ` Manish Ahuja
2008-04-09 19:39 ` Segher Boessenkool [this message]
2008-04-10 1:36 ` Paul Mackerras
2008-04-10 3:10 ` Segher Boessenkool
2008-04-09 17:37 ` Manish Ahuja
2008-04-09 18:30 ` Olof Johansson
2008-04-09 18:43 ` Manish Ahuja
2008-04-09 18:59 ` Olof Johansson
2008-04-11 23:31 ` Manish Ahuja
2008-04-15 6:24 ` Paul Mackerras
2008-04-15 22:56 ` Manish Ahuja
2008-04-16 19:42 ` Joel Schopp
2008-04-16 20:22 ` Linas Vepstas
2008-04-18 19:08 ` Manish Ahuja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76b6f0069fd6d80f69620e39c8528e9d@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=ahuja@austin.ibm.com \
--cc=linasvepstas@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahuja@us.ibm.com \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).