From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29CA1CD5BB4 for ; Tue, 26 May 2026 06:33:31 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gPjcp3kz4z2y8t; Tue, 26 May 2026 16:33:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779777210; cv=none; b=AVX3QnrmmLf8uu6AtdW1vj9k2RkCZdplZALpaL4wf1xNZ/USTTPJVTgTTNMuSLPPVcupBRtaEyR1yTBnPvH9pOrALDMSh1sOTjzw4IPWXTpPn5qLcXnkxn6366wxB9pSHiUTtgQLmM+3qpnM+ek0TW1TqNjM7GsbQYKP/SdfO6J+6PLhfwzGR7CQfTB6sBiIxMxCUKH81k42C6cLyYJBPLoivuqHxZe/T0gSAIUIIRrP2Us9fhuimTLWZqi6AmCqlutj6be7S5abIvRYKy19E2qDxnmrSwuqnzEifBQ1mH7Hin9oX56IWAdaJ20/bgi/vAB5VkP3QG7NQ6ekWSe+Aw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779777210; c=relaxed/relaxed; bh=lSSTgIJxElpRPZXCwCiqCKzOkrKn0h4qZngFuiv7DgQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UOf4qDKSFUyFXXfUr+AWehYIygrGXXoa8k0pVz7kkwPsifo9VFoaIgbRmlIIfCZbzMKBn1QmGvDdHM73+uc1E1/pR8j//pTuQg69nSS+1WVxuj1UMFRVwn1OuExXQp01DJmQ2BrkWa4UYnvl3OZmtlXoQguwCJsCCRSi+5NglEZ2bl4XQ51Vhh/fD0q8Tl8ZXPuX0JfAcBLZPOn2L7UK30MaDu1g6Jtwg7jXJ9D11ZMV14C/VnlvoLPXFPakXlZS/eOZMbBrYGsps03SyOuPFVmfshiBgu7dmTLPmg4HRumCw3gkF9oJEhLd0tl+/4UqkqvOj+2njequoiID1LmbfQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cpfdUPE5; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=harshpb@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cpfdUPE5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=harshpb@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gPjcm3bJsz2xHK for ; Tue, 26 May 2026 16:33:27 +1000 (AEST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64PN5oCG4112531; Tue, 26 May 2026 06:33:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=lSSTgI JxElpRPZXCwCiqCKzOkrKn0h4qZngFuiv7DgQ=; b=cpfdUPE5GXZtk7jlSz6ZR/ 9gZW04DexbKzX0Ao2CT9354Iq2VdPZ2LkuXTN020t0l+7B4S649D87v25jlxY+Z1 fptQYAGSz4U5aA71XLqZ1+H3eQpa7MDV5OebBvNT3zPJqwCxtO8XZwiyvCKZW5MP vNjZ7GOVmQmOFsP4ubf8V4Him10gnMSvo6Q7A6UvS6mY/vhC/3AqKH1kb7LNpw7O kK7Yapbyl/J5v1llS2nr+NsDqecbtAf9nkMrdYO9JZUk5E+sQenhTiu3kVQOb9oN vN+A7y4ar4YBnHSMpgpwI4Ob/Cor1Wx5MmfeegXRaDOVBfx0sRlOjBwPGHH/R2DA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eb4pd9t75-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 May 2026 06:33:06 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64Q6O35j009870; Tue, 26 May 2026 06:33:06 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ebqjjr3xx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 May 2026 06:33:06 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64Q6X5mr30147200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 May 2026 06:33:05 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C7D958055; Tue, 26 May 2026 06:33:05 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1FE0558043; Tue, 26 May 2026 06:33:00 +0000 (GMT) Received: from [9.123.0.169] (unknown [9.123.0.169]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 26 May 2026 06:32:59 +0000 (GMT) Message-ID: <76f82194-9afb-4dfe-ad96-ae338c7db61d@linux.ibm.com> Date: Tue, 26 May 2026 12:02:58 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KVM: Validate irqchip index for LoongArch and PowerPC Content-Language: en-GB To: Yanfei Xu , zhaotianrui@loongson.cn, maobibo@loongson.cn, chenhuacai@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, sashiko-reviews@lists.linux.dev, seanjc@google.com, pbonzini@redhat.com Cc: kvm@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, caixiangfeng@bytedance.com, fangying.tommy@bytedance.com, isyanfei.xu@gmail.com, Sashiko , stable@vger.kernel.org References: <20260525070154.495455-1-yanfei.xu@bytedance.com> From: Harsh Prateek Bora In-Reply-To: <20260525070154.495455-1-yanfei.xu@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=OdqoyBTY c=1 sm=1 tr=0 ts=6a153ea3 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=f7IdgyKtn90A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VwQbUJbxAAAA:8 a=968KyxNXAAAA:8 a=VnNF1IyMAAAA:8 a=VhF_hiyGZBDqKw0Zxd0A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: LRBMiiFu8R_IMzxWSnnQX7_Q9AYoCXuw X-Proofpoint-ORIG-GUID: 5_W0oqDVcmHgDExfvwT3FxNm3zkLR1hH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA1MSBTYWx0ZWRfX90z2vKmC0yAk CWSucWXg+h4/Q/KVFzuUyOVTM3Ffn5pOF70e9b6dUfaJEKlTKVS5FhR0ih3lCU5NshKV2HubsWL SLfOz2KgQyFTWyDyk2c5VFMWK1WwrBK2V9He1yI9qH2vWFfu8CbOiIp2svrl8Uq45ssuZG3u1Ui cuswYiUbKsINKddCpffjDXQZri/svJx49y8R9X0UXJ5QeIaEer68I3nADevAk7o7ZS6KHC7DBh7 MG28r5i57DGfw6xEXwCLKnf0V7ak8mqhnXdEfVg1oz1XtuJKej7DUYpLPsxWAu1QchEvUJRRzOU iv4n2vwDpREmpc8NxtC0O7SgemcbY5bh0qeZ95hhSCXTfhTLcwq9eHdse9QCZxpX66x3iCn1oei xB1qrl0z7NgLSMif/uc2QI9feykHP1Y9tJixKyB/lftuVZyDsUVJxUFB8gmLDmtZlH8qNq8mrER 2NZy1yKpnBXTVaXu5PQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-26_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260051 + cc: stable@vger.kernel.org On 25/05/26 12:31 pm, Yanfei Xu wrote: > Sashiko reported that irqchip index is not validated for LoongArch and > PowerPC. Add validation and reject out-of-range irqchip indexes to avoid > indexing past the routing table's chip array. > > Fixes: de9ba2f36368 ("KVM: PPC: Support irq routing and irqfd for in-kernel MPIC") > Fixes: 1928254c5ccb ("LoongArch: KVM: Add irqfd support") > Reported-by: Sashiko > Closes: https://lore.kernel.org/kvm/20260525051714.485D51F000E9@smtp.kernel.org/ > Signed-off-by: Yanfei Xu > --- > arch/loongarch/kvm/irqfd.c | 3 ++- > arch/powerpc/kvm/mpic.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/loongarch/kvm/irqfd.c b/arch/loongarch/kvm/irqfd.c > index f4f953b22419..40ed1081c4b6 100644 > --- a/arch/loongarch/kvm/irqfd.c > +++ b/arch/loongarch/kvm/irqfd.c > @@ -51,7 +51,8 @@ int kvm_set_routing_entry(struct kvm *kvm, > e->irqchip.irqchip = ue->u.irqchip.irqchip; > e->irqchip.pin = ue->u.irqchip.pin; > > - if (e->irqchip.pin >= KVM_IRQCHIP_NUM_PINS) > + if (e->irqchip.pin >= KVM_IRQCHIP_NUM_PINS || > + e->irqchip.irqchip >= KVM_NR_IRQCHIPS) > return -EINVAL; > > return 0; > diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c > index 3070f36d9fb8..fb5f9e65e02e 100644 > --- a/arch/powerpc/kvm/mpic.c > +++ b/arch/powerpc/kvm/mpic.c > @@ -1833,7 +1833,8 @@ int kvm_set_routing_entry(struct kvm *kvm, > e->set = mpic_set_irq; > e->irqchip.irqchip = ue->u.irqchip.irqchip; > e->irqchip.pin = ue->u.irqchip.pin; > - if (e->irqchip.pin >= KVM_IRQCHIP_NUM_PINS) > + if (e->irqchip.pin >= KVM_IRQCHIP_NUM_PINS || > + e->irqchip.irqchip >= KVM_NR_IRQCHIPS) Reviewed-by: Harsh Prateek Bora # PPC KVM > goto out; > break; > case KVM_IRQ_ROUTING_MSI: