From: Joe Lawrence <joe.lawrence@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>, Petr Mladek <pmladek@suse.com>
Cc: live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>,
Ryan Sullivan <rysulliv@redhat.com>
Subject: Re: Recent Power changes and stack_trace_save_tsk_reliable?
Date: Thu, 21 Sep 2023 09:22:47 -0400 [thread overview]
Message-ID: <77033ba0-9786-62c6-d3fd-ad1226017c09@redhat.com> (raw)
In-Reply-To: <8734z7ogpd.fsf@mail.lhotse>
On 9/21/23 08:26, Michael Ellerman wrote:
> Petr Mladek <pmladek@suse.com> writes:
>> On Wed 2023-08-30 17:47:35, Joe Lawrence wrote:
>>> On 8/30/23 02:37, Michael Ellerman wrote:
>>>> Michael Ellerman <mpe@ellerman.id.au> writes:
>>>>> Joe Lawrence <joe.lawrence@redhat.com> writes:
>>>>>> We noticed that our kpatch integration tests started failing on ppc64le
>>>>>> when targeting the upstream v6.4 kernel, and then confirmed that the
>>>>>> in-tree livepatching kselftests similarly fail, too. From the kselftest
>>>>>> results, it appears that livepatch transitions are no longer completing.
> ...
>>>>
>>>> The diff below fixes it for me, can you test that on your setup?
>>>>
>>>
>>> Thanks for the fast triage of this one. The proposed fix works well on
>>> our setup. I have yet to try the kpatch integration tests with this,
>>> but I can verify that all of the kernel livepatching kselftests now
>>> happily run.
>>
>> Have this been somehow handled, please? I do not see the proposed
>> change in linux-next as of now.
>
> I thought I was waiting for Joe to run the kpatch integration tests, but
> in hindsight maybe he was hinting that someone else should run them (ie. me) ;)
>
> Patch incoming.
Ah sorry for the confusion. kpatch integration tests - that's on me.
If kernel stack unwinding is fixed, I'm pretty confident they will
execute. I will kick them off today, but don't let that hold up the
kernel patches.
Thanks,
--
Joe
prev parent reply other threads:[~2023-09-21 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 15:12 Recent Power changes and stack_trace_save_tsk_reliable? Joe Lawrence
2023-08-30 0:32 ` Michael Ellerman
2023-08-30 6:37 ` Michael Ellerman
2023-08-30 21:47 ` Joe Lawrence
2023-09-20 14:16 ` Petr Mladek
2023-09-21 12:26 ` Michael Ellerman
2023-09-21 13:22 ` Joe Lawrence [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77033ba0-9786-62c6-d3fd-ad1226017c09@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=rysulliv@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).