From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Oliver O'Halloran <oohall@gmail.com>,
linux-efi@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Tony Luck <tony.luck@intel.com>, Paolo Abeni <pabeni@redhat.com>,
linux-pci@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Netdev <netdev@vger.kernel.org>, Borislav Petkov <bp@alien8.de>,
Jakub Kicinski <kuba@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org, linuxppc-dev@lists.ozlabs.org,
Ard Biesheuvel <ardb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing
Date: Fri, 22 Mar 2024 16:16:37 +0200 (EET) [thread overview]
Message-ID: <771bb522-c4eb-b515-e315-6ad1c622cbd9@linux.intel.com> (raw)
In-Reply-To: <cc3f6a32-a00d-3c68-bc89-c042d238e7fe@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On Mon, 11 Mar 2024, Ilpo Järvinen wrote:
> On Fri, 8 Mar 2024, Bjorn Helgaas wrote:
>
> > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote:
> > > This series consolidates AER & DPC TLP Log handling code. Helpers are
> > > added for reading and printing the TLP Log and the format is made to
> > > include E-E Prefixes in both cases (previously only one DPC RP PIO
> > > displayed the E-E Prefixes).
> > >
> > > I'd appreciate if people familiar with ixgbe could check the error
> > > handling conversion within the driver is correct.
> > >
> > > Ilpo Järvinen (4):
> > > PCI/AER: Cleanup register variable
> > > PCI: Generalize TLP Header Log reading
> >
> > I applied these first two to pci/aer for v6.9, thanks, these are all
> > nice improvements!
> >
> > I postponed the ixgbe part for now because I think we should get an
> > ack from those maintainers or just send it to them since it subtly
> > changes the error and device removal checking there.
>
> Okay, I'll make sure they're separated properly for the remaining patches
> (I was already planning on doing that separation and posting v2 to avoid
> their input blocking the changed but you beat me to it).
>
> > > PCI: Add TLP Prefix reading into pcie_read_tlp_log()
> > > PCI: Create helper to print TLP Header and Prefix Log
> >
> > I'll respond to these with some minor comments.
>
> Did you forget to send those comments?
Ping.
I still haven't received those comments for patches 3 & 4.
--
i.
prev parent reply other threads:[~2024-03-22 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:57 [PATCH 0/4] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-02-06 13:57 ` [PATCH 1/4] PCI/AER: Cleanup register variable Ilpo Järvinen
2024-02-06 13:57 ` [PATCH 2/4] PCI: Generalize TLP Header Log reading Ilpo Järvinen
2024-03-14 17:16 ` Bjorn Helgaas
2024-02-06 13:57 ` [PATCH 3/4] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2024-03-22 19:30 ` Bjorn Helgaas
2024-02-06 13:57 ` [PATCH 4/4] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
2024-02-07 11:50 ` [PATCH 0/4] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-03-08 21:31 ` Bjorn Helgaas
2024-03-11 11:34 ` Ilpo Järvinen
2024-03-22 14:16 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771bb522-c4eb-b515-e315-6ad1c622cbd9@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=oohall@gmail.com \
--cc=pabeni@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).