From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5628C43331 for ; Tue, 24 Mar 2020 15:10:00 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 690E020775 for ; Tue, 24 Mar 2020 15:10:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 690E020775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48mvn13WXzzDqpG for ; Wed, 25 Mar 2020 02:09:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=46.105.34.113; helo=3.mo7.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kaod.org X-Greylist: delayed 937 seconds by postgrey-1.36 at bilbo; Wed, 25 Mar 2020 02:05:03 AEDT Received: from 3.mo7.mail-out.ovh.net (3.mo7.mail-out.ovh.net [46.105.34.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48mvgM43HYzDqQ6 for ; Wed, 25 Mar 2020 02:04:59 +1100 (AEDT) Received: from player778.ha.ovh.net (unknown [10.110.208.115]) by mo7.mail-out.ovh.net (Postfix) with ESMTP id C784515A7DB for ; Tue, 24 Mar 2020 15:49:16 +0100 (CET) Received: from kaod.org (82-64-250-170.subs.proxad.net [82.64.250.170]) (Authenticated sender: clg@kaod.org) by player778.ha.ovh.net (Postfix) with ESMTPSA id ED91010C2D8A8; Tue, 24 Mar 2020 14:48:55 +0000 (UTC) Subject: Re: [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address To: Haren Myneni , mpe@ellerman.id.au References: <1584598120.9256.15237.camel@hbabu-laptop> <1584598473.9256.15248.camel@hbabu-laptop> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <7793f6d4-770b-5fd0-f177-651130c0ff53@kaod.org> Date: Tue, 24 Mar 2020 15:48:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1584598473.9256.15248.camel@hbabu-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 2156098321623583599 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudehuddgfeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucfkpheptddrtddrtddrtddpkedvrdeigedrvdehtddrudejtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejjeekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtoheplhhinhhugihpphgtqdguvghvsehlihhsthhsrdhoiihlrggsshdrohhrgh X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, Frederic Bonnard , herbert@gondor.apana.org.au, npiggin@gmail.com, hch@infradead.org, oohall@gmail.com, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, ajd@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 3/19/20 7:14 AM, Haren Myneni wrote: > > Alloc IRQ and get trigger port address for each VAS instance. Kernel > register this IRQ per VAS instance and sets this port for each send > window. NX interrupts the kernel when it sees page fault. > > Signed-off-by: Haren Myneni > --- > arch/powerpc/platforms/powernv/vas.c | 34 ++++++++++++++++++++++++++++------ > arch/powerpc/platforms/powernv/vas.h | 2 ++ > 2 files changed, 30 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/vas.c b/arch/powerpc/platforms/powernv/vas.c > index ed9cc6d..168ab68 100644 > --- a/arch/powerpc/platforms/powernv/vas.c > +++ b/arch/powerpc/platforms/powernv/vas.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include "vas.h" > > @@ -25,10 +26,12 @@ > > static int init_vas_instance(struct platform_device *pdev) > { > - int rc, cpu, vasid; > - struct resource *res; > - struct vas_instance *vinst; > struct device_node *dn = pdev->dev.of_node; > + struct vas_instance *vinst; > + uint32_t chipid, irq; > + struct resource *res; > + int rc, cpu, vasid; > + uint64_t port; > > rc = of_property_read_u32(dn, "ibm,vas-id", &vasid); > if (rc) { > @@ -36,6 +39,12 @@ static int init_vas_instance(struct platform_device *pdev) > return -ENODEV; > } > > + rc = of_property_read_u32(dn, "ibm,chip-id", &chipid); > + if (rc) { > + pr_err("No ibm,chip-id property for %s?\n", pdev->name); > + return -ENODEV; > + } > + > if (pdev->num_resources != 4) { > pr_err("Unexpected DT configuration for [%s, %d]\n", > pdev->name, vasid); > @@ -69,9 +78,22 @@ static int init_vas_instance(struct platform_device *pdev) > > vinst->paste_win_id_shift = 63 - res->end; > > - pr_devel("Initialized instance [%s, %d], paste_base 0x%llx, " > - "paste_win_id_shift 0x%llx\n", pdev->name, vasid, > - vinst->paste_base_addr, vinst->paste_win_id_shift); > + rc = xive_native_alloc_get_irq_info(chipid, &irq, &port); > + if (rc) > + return rc; > + > + vinst->virq = irq_create_mapping(NULL, irq); > + if (!vinst->virq) { > + pr_err("Inst%d: Unable to map global irq %d\n", > + vinst->vas_id, irq); > + return -EINVAL; > + } > + > + vinst->irq_port = port; I would prefer something like this : hwirq = xive_native_alloc_irq_on_chip(chip_id); vinst->virq = irq_create_mapping(NULL, hwirq); if (!vinst->virq) { ... } { struct irq_data *d = irq_get_irq_data(vinst->virq); struct xive_irq_data *xd = irq_data_get_irq_handler_data(d); vinst->irq_port = xd->trig_page; } and dump xive_native_alloc_get_irq_info(). C. > + pr_devel("Initialized instance [%s, %d] paste_base 0x%llx paste_win_id_shift 0x%llx IRQ %d Port 0x%llx\n", > + pdev->name, vasid, vinst->paste_base_addr, > + vinst->paste_win_id_shift, vinst->virq, > + vinst->irq_port); > > for_each_possible_cpu(cpu) { > if (cpu_to_chip_id(cpu) == of_get_ibm_chip_id(dn)) > diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h > index 5574aec..598608b 100644 > --- a/arch/powerpc/platforms/powernv/vas.h > +++ b/arch/powerpc/platforms/powernv/vas.h > @@ -313,6 +313,8 @@ struct vas_instance { > u64 paste_base_addr; > u64 paste_win_id_shift; > > + u64 irq_port; > + int virq; > struct mutex mutex; > struct vas_window *rxwin[VAS_COP_TYPE_MAX]; > struct vas_window *windows[VAS_WINDOWS_PER_CHIP]; >