Re: [PATCH] arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files

Re: [PATCH] arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files

[Geert Uytterhoeven]

Hi Thomas,

CC arm/mips/ppc, as you sent similar patches for these arches.

On Wed, 1 Apr 2026 at 10:40, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> CONFIG_FIRMWARE_EDID=y depends on X86 or EFI_GENERIC_STUB. Neither is
> true here, so drop the lines from the defconfig files.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for your patch!

Upon first look, your changes match the (current) dependencies
of FIRMWARE_EDID.  The dependency on X86 was added in commit
7e35fc7ab433683f ("video: Make CONFIG_FIRMWARE_EDID generally
available") in v6.17-rc1.
However, CONFIG_FIRMWARE_EDID also protects fb_firmware_edid(),
which seems to extract the EDID from the PCI ROM, and is thus not
x86-specific?  That function is only ever called by three fbdev drivers
(i810, nv, savagefb), though.

I assume none of these work on SuperH, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files

[Thomas Zimmermann]

Hi Geert

Am 01.04.26 um 10:55 schrieb Geert Uytterhoeven:
> Hi Thomas,
>
> CC arm/mips/ppc, as you sent similar patches for these arches.
>
> On Wed, 1 Apr 2026 at 10:40, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> CONFIG_FIRMWARE_EDID=y depends on X86 or EFI_GENERIC_STUB. Neither is
>> true here, so drop the lines from the defconfig files.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Thanks for your patch!
>
> Upon first look, your changes match the (current) dependencies
> of FIRMWARE_EDID.  The dependency on X86 was added in commit
> 7e35fc7ab433683f ("video: Make CONFIG_FIRMWARE_EDID generally
> available") in v6.17-rc1.
> However, CONFIG_FIRMWARE_EDID also protects fb_firmware_edid(),
> which seems to extract the EDID from the PCI ROM, and is thus not

The PCI code in the function tests whether the BIOS ROM has been 
shadowed into system memory. That's a common way of testing if the PCI 
device is the primary graphics card. The provided EDID is only for the 
primary device.

The test shouldn't actually be there any more. We now have 
video_is_primary_device() for this.

> x86-specific?  That function is only ever called by three fbdev drivers
> (i810, nv, savagefb), though.

I know. But IDK why it hasn't been more prominently featured in fbdev.  
Nowadays, we use the firmware EDID with DRM's generic drivers on any 
hardware.

>
> I assume none of these work on SuperH, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks

Best regards
Thomas

>
> Gr{oetje,eeting}s,
>
>                          Geert
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)