From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C54C8D35160 for ; Wed, 1 Apr 2026 09:08:02 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4flzfT31gHz2ygY; Wed, 01 Apr 2026 20:08:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a07:de40:b251:101:10:150:64:2" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775034481; cv=none; b=YbuD1tdKGgdJv9+NOC3coficVAC55SMBVAS612dGAgnvf0zGVvDq/Hu9zy0qYR7o0yB0UR1S0hrRHzEpa2ls8s0zNCDilmn+4HRKO956S2iRcnjqMjrr8blIINpk20y7vL69anoDH7NqXYI5fE+wXiGXtw0RUgJodf37jINI5JbZxMLGla7Zo56bIFgFWQKY1S/1bxCZaLULpwFE8n96kQ3+8hit3SVsOlD8QyV8VeBQpEsK6TdvEv3ZB7KDP7uZCdnU1HuIxvXHczhEYWtmHN5abRgM8Ewl7jz8D37vpJ17L1AlNMlrx+mRGRzC1+tcV7s2MBWUvgPojV/InXh1Xg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775034481; c=relaxed/relaxed; bh=sbQafpbHS8QlsoJuzus20KUSokVPO3m/Lk8X75FkK60=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KeJiSyv9fAXta22TNBA8HDxjy5zJtB/Ba+qWNkqRy4t+90xtO7Q/CCfxksSzJwIAjUsvRddv4i76R+IwGoopVKX++epgKk116hyN7lpnBeKiSHkAXCyQzYM60iM6EAPfUBYEQ74ovYeBiXGV16GnRmeHzbA0QNbo8DkdEKKLnV2sIov33kIASsUtJu++fTssu7cUuv4d/jcEqKcT+xKrKGH3IUOXkyImxVY7Do+mahVDgLodfaeblKphLOblGjZYe2qtJxZdOVhB2Y6o6pLOzj/1xpxQlJ/nVgf9ZOE30UrAxHegwtjtKQ59TVWv2UOL5trZ0M9TH854mPPgOmlCXg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=tzimmermann@suse.de; receiver=lists.ozlabs.org) smtp.mailfrom=suse.de Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=tzimmermann@suse.de; receiver=lists.ozlabs.org) X-Greylist: delayed 2250 seconds by postgrey-1.37 at boromir; Wed, 01 Apr 2026 20:08:00 AEDT Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4flzfS1bRtz2ySY for ; Wed, 01 Apr 2026 20:07:59 +1100 (AEDT) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E9B195BD44; Wed, 1 Apr 2026 09:07:56 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 976D04A0B0; Wed, 1 Apr 2026 09:07:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NhNPI2zgzGm1LwAAD6G6ig (envelope-from ); Wed, 01 Apr 2026 09:07:56 +0000 Message-ID: <786390ea-e42c-4d9f-be55-09093cf09918@suse.de> Date: Wed, 1 Apr 2026 11:07:56 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files To: Geert Uytterhoeven Cc: ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, arnd@arndb.de, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Linux ARM , linuxppc-dev , linux-mips@vger.kernel.org References: <20260401083242.214492-1-tzimmermann@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: E9B195BD44 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Hi Geert Am 01.04.26 um 10:55 schrieb Geert Uytterhoeven: > Hi Thomas, > > CC arm/mips/ppc, as you sent similar patches for these arches. > > On Wed, 1 Apr 2026 at 10:40, Thomas Zimmermann wrote: >> CONFIG_FIRMWARE_EDID=y depends on X86 or EFI_GENERIC_STUB. Neither is >> true here, so drop the lines from the defconfig files. >> >> Signed-off-by: Thomas Zimmermann > Thanks for your patch! > > Upon first look, your changes match the (current) dependencies > of FIRMWARE_EDID. The dependency on X86 was added in commit > 7e35fc7ab433683f ("video: Make CONFIG_FIRMWARE_EDID generally > available") in v6.17-rc1. > However, CONFIG_FIRMWARE_EDID also protects fb_firmware_edid(), > which seems to extract the EDID from the PCI ROM, and is thus not The PCI code in the function tests whether the BIOS ROM has been shadowed into system memory. That's a common way of testing if the PCI device is the primary graphics card. The provided EDID is only for the primary device. The test shouldn't actually be there any more. We now have video_is_primary_device() for this. > x86-specific? That function is only ever called by three fbdev drivers > (i810, nv, savagefb), though. I know. But IDK why it hasn't been more prominently featured in fbdev.  Nowadays, we use the firmware EDID with DRM's generic drivers on any hardware. > > I assume none of these work on SuperH, so > Reviewed-by: Geert Uytterhoeven Thanks Best regards Thomas > > Gr{oetje,eeting}s, > > Geert > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)