linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cxl/ocxl: Possible repeated word
       [not found] <20230618150648.1123-1-dengshaomin@cdjrlc.com>
@ 2023-06-18 15:08 ` zhumao001
  2023-06-20  7:43   ` Frederic Barrat
  2023-06-20 12:18   ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: zhumao001 @ 2023-06-18 15:08 UTC (permalink / raw)
  To: fbarrat, ajd, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]


Delete repeated word in comment.

Signed-off-by: Zhu Mao <zhumao001@208suo.com>
---
  drivers/misc/cxl/native.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
index 50b0c44bb8d7..6957946a6463 100644
--- a/drivers/misc/cxl/native.c
+++ b/drivers/misc/cxl/native.c
@@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct 
cxl_context *ctx, u64 wed, u64 amr)
       * Ideally we should do a wmb() here to make sure the changes to 
the
       * PE are visible to the card before we call afu_enable.
       * On ppc64 though all mmios are preceded by a 'sync' instruction 
hence
-     * we dont dont need one here.
+     * we dont need one here.
       */

      result = cxl_ops->afu_reset(afu);

[-- Attachment #2: Type: text/html, Size: 1328 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cxl/ocxl: Possible repeated word
  2023-06-18 15:08 ` [PATCH] cxl/ocxl: Possible repeated word zhumao001
@ 2023-06-20  7:43   ` Frederic Barrat
  2023-06-20 12:18   ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Frederic Barrat @ 2023-06-20  7:43 UTC (permalink / raw)
  To: zhumao001, ajd, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel


Hello,

While the correction in the comment is of course ok, the patch was sent 
as html. You may want to check/fix how it was submitted.

   Fred


On 18/06/2023 17:08, zhumao001@208suo.com wrote:
> Delete repeated word in comment. Signed-off-by: Zhu Mao <zhumao001@ 
>  208suo. com> --- drivers/misc/cxl/native. c | 2 +- 1 file changed, 1 
> insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/native. c 
> b/drivers/misc/cxl/native. cindex
> ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!2k-hI76VihO6WgXx-IHFLxDVOAL2DdWMKjPu4ApiehtDXYjNrTR1Cj6nYDmD8SP9M8AZ7TpWUloL0Ixn_2IX60uI2MsuBkM$>
> ZjQcmQRYFpfptBannerEnd
> Delete repeated word in comment.
> 
> Signed-off-by: Zhu Mao <zhumao001@208suo.com>
> ---
>   drivers/misc/cxl/native.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
> index 50b0c44bb8d7..6957946a6463 100644
> --- a/drivers/misc/cxl/native.c
> +++ b/drivers/misc/cxl/native.c
> @@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct 
> cxl_context *ctx, u64 wed, u64 amr)
>        * Ideally we should do a wmb() here to make sure the changes to the
>        * PE are visible to the card before we call afu_enable.
>        * On ppc64 though all mmios are preceded by a 'sync' instruction 
> hence
> -     * we dont dont need one here.
> +     * we dont need one here.
>        */
> 
>       result = cxl_ops->afu_reset(afu);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cxl/ocxl: Possible repeated word
  2023-06-18 15:08 ` [PATCH] cxl/ocxl: Possible repeated word zhumao001
  2023-06-20  7:43   ` Frederic Barrat
@ 2023-06-20 12:18   ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2023-06-20 12:18 UTC (permalink / raw)
  To: zhumao001, fbarrat, ajd, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel

zhumao001@208suo.com writes:
> Delete repeated word in comment.
>
> Signed-off-by: Zhu Mao <zhumao001@208suo.com>
> ---
>   drivers/misc/cxl/native.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
> index 50b0c44bb8d7..6957946a6463 100644
> --- a/drivers/misc/cxl/native.c
> +++ b/drivers/misc/cxl/native.c
> @@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct 
> cxl_context *ctx, u64 wed, u64 amr)
>        * Ideally we should do a wmb() here to make sure the changes to 
> the
>        * PE are visible to the card before we call afu_enable.
>        * On ppc64 though all mmios are preceded by a 'sync' instruction 
> hence
> -     * we dont dont need one here.
> +     * we dont need one here.

I know the rule is to only do one change per patch, but if you're fixing
the wording of a comment you can absolutely fix the spelling at the same
time.

So please send a v2 with "dont" spelt correctly.

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-20 12:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230618150648.1123-1-dengshaomin@cdjrlc.com>
2023-06-18 15:08 ` [PATCH] cxl/ocxl: Possible repeated word zhumao001
2023-06-20  7:43   ` Frederic Barrat
2023-06-20 12:18   ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).