From: Michael Neuling <mikey@neuling.org>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
Haren Myneni <haren@linux.vnet.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH] powerpc: Avoid code patching freed init sections
Date: Mon, 10 Sep 2018 20:05:38 +1000 [thread overview]
Message-ID: <794308ed6aa6dcccf96e10bb0e3fa8d2dab9adff.camel@neuling.org> (raw)
In-Reply-To: <20180910115457.60366160@naga.suse.cz>
> > + /* Make sure we aren't patching a freed init section */
> > + if (in_init_section(patch_addr) && init_freed())
> > + return 0;
> > +
>=20
> Do we even need the init_freed() check?
Maybe not. If userspace isn't up, then maybe it's ok to skip.
> What user input can we process in init-only code?
See the stack trace in the commit message. It's a weird case for KVM guests=
in
KVM PR mode.=20
That's the only case I can found so far.
> Also it would be nice to write the function+offset of the skipped patch
> location into the kernel log.
OK. I'll update.
Mikey
next prev parent reply other threads:[~2018-09-10 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 5:44 [PATCH] powerpc: Avoid code patching freed init sections Michael Neuling
2018-09-10 8:10 ` Michal Suchánek
2018-09-10 10:01 ` Michael Neuling
2018-09-10 9:54 ` Michal Suchánek
2018-09-10 10:05 ` Michael Neuling [this message]
2018-09-10 10:16 ` Christophe LEROY
2018-09-10 10:44 ` Michal Suchánek
2018-09-10 22:38 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794308ed6aa6dcccf96e10bb0e3fa8d2dab9adff.camel@neuling.org \
--to=mikey@neuling.org \
--cc=haren@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).