From: Michael Neuling <mikey@neuling.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
bg-linux@lists.anl-external.org
Subject: Re: [PATCH] [RFC][V3] bluegene: add entry to cpu table
Date: Wed, 08 Jun 2011 15:37:58 +1000 [thread overview]
Message-ID: <7945.1307511478@neuling.org> (raw)
In-Reply-To: <1307494181.2874.214.camel@pasglop>
> > Create an entry for the BG/P chips, include bits to accomodate
> > the double fp2 fpu and the special MMU considerations like L1
> > writethrough.
> >
> > RFC Note: this patch fails scripts/checkpatch.pl because I
> > matched coding style of the surrounding existing code. Would
> > you rather have something checkpatch.pl clean or something
> > which is consistent with the surrounding code style?
>
> Stay consistent. You're welcome to my next checkpatch burning
> ceremony :-)
I'll make t-shirts for us!
> > #define PPC_FEATURE_POWER6_EXT 0x00000200
> > #define PPC_FEATURE_ARCH_2_06 0x00000100
> > #define PPC_FEATURE_HAS_VSX 0x00000080
> > +#define PPC_FEATURE_HAS_FPU_FP2 0x00000040
>
> Any chance for a better name ?
I've painted this particular bike shed with Eric already :-)
It's an extension to the FPU called FP2
(https://wiki.alcf.anl.gov/images/d/d9/PPC440_FP2_arch.pdf).
So PPC_FEATURE_HAS_FPU -> PPC_FEATURE_HAS_FPU_FP2.
I think the name is right as he has it.
Mikey
prev parent reply other threads:[~2011-06-08 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 18:47 [PATCH] [RFC][V3] bluegene: add entry to cpu table Eric Van Hensbergen
2011-06-08 0:49 ` Benjamin Herrenschmidt
2011-06-08 2:10 ` Eric Van Hensbergen
2011-06-08 5:37 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7945.1307511478@neuling.org \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=bg-linux@lists.anl-external.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).