linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/of: add OF_DYNAMIC for chroma
@ 2012-02-19 22:48 Michael Neuling
  2012-02-20 14:12 ` Jimi Xenidis
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Neuling @ 2012-02-19 22:48 UTC (permalink / raw)
  To: Jimi Xenidis, grant.likely; +Cc: linuxppc-dev, linux-next

linux next-20120217 compiling ppc64e_defconfig fails with:

arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of function 'of_detach_node'

The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig
index 57d22a2..79d2225 100644
--- a/arch/powerpc/platforms/wsp/Kconfig
+++ b/arch/powerpc/platforms/wsp/Kconfig
@@ -25,6 +25,7 @@ config PPC_CHROMA
 	bool "PowerEN PCIe Chroma Card"
 	select EPAPR_BOOT
 	select PPC_WSP
+	select OF_DYNAMIC
 	default y
 
 endmenu

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/of: add OF_DYNAMIC for chroma
  2012-02-19 22:48 [PATCH] powerpc/of: add OF_DYNAMIC for chroma Michael Neuling
@ 2012-02-20 14:12 ` Jimi Xenidis
  2012-02-20 23:16   ` Michael Neuling
  0 siblings, 1 reply; 3+ messages in thread
From: Jimi Xenidis @ 2012-02-20 14:12 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, linux-next


On Feb 19, 2012, at 4:48 PM, Michael Neuling wrote:

> linux next-20120217 compiling ppc64e_defconfig fails with:
>=20
> arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
> arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of =
function 'of_detach_node'
>=20
> The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.
>=20
> Signed-off-by: Michael Neuling <mikey@neuling.org>

Acked-by: Jimi Xenidis <jimix@pobox.com>

>=20
> diff --git a/arch/powerpc/platforms/wsp/Kconfig =
b/arch/powerpc/platforms/wsp/Kconfig
> index 57d22a2..79d2225 100644
> --- a/arch/powerpc/platforms/wsp/Kconfig
> +++ b/arch/powerpc/platforms/wsp/Kconfig
> @@ -25,6 +25,7 @@ config PPC_CHROMA
> 	bool "PowerEN PCIe Chroma Card"
> 	select EPAPR_BOOT
> 	select PPC_WSP
> +	select OF_DYNAMIC
> 	default y
>=20
> endmenu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/of: add OF_DYNAMIC for chroma
  2012-02-20 14:12 ` Jimi Xenidis
@ 2012-02-20 23:16   ` Michael Neuling
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Neuling @ 2012-02-20 23:16 UTC (permalink / raw)
  To: Jimi Xenidis; +Cc: linuxppc-dev, linux-next

Grant, 

This seems to be broken in your tree (since 301b605ff6), so you should
probably pick up this patch.

Mikey


In message <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com> you wrote:
> 
> On Feb 19, 2012, at 4:48 PM, Michael Neuling wrote:
> 
> > linux next-20120217 compiling ppc64e_defconfig fails with:
> >=20
> > arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
> > arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of =
> function 'of_detach_node'
> >=20
> > The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> Acked-by: Jimi Xenidis <jimix@pobox.com>
> 
> >=20
> > diff --git a/arch/powerpc/platforms/wsp/Kconfig =
> b/arch/powerpc/platforms/wsp/Kconfig
> > index 57d22a2..79d2225 100644
> > --- a/arch/powerpc/platforms/wsp/Kconfig
> > +++ b/arch/powerpc/platforms/wsp/Kconfig
> > @@ -25,6 +25,7 @@ config PPC_CHROMA
> > 	bool "PowerEN PCIe Chroma Card"
> > 	select EPAPR_BOOT
> > 	select PPC_WSP
> > +	select OF_DYNAMIC
> > 	default y
> >=20
> > endmenu
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-20 23:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-19 22:48 [PATCH] powerpc/of: add OF_DYNAMIC for chroma Michael Neuling
2012-02-20 14:12 ` Jimi Xenidis
2012-02-20 23:16   ` Michael Neuling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).