From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mikey@neuling.org>
From: Michael Neuling <mikey@neuling.org>
To: Jimi Xenidis <jimix@pobox.com>
Subject: Re: [PATCH] powerpc/of: add OF_DYNAMIC for chroma
In-reply-to: <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com>
References: <5145.1329691681@neuling.org>
 <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com>
Date: Tue, 21 Feb 2012 10:16:10 +1100
Message-ID: <7970.1329779770@neuling.org>
Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

Grant, 

This seems to be broken in your tree (since 301b605ff6), so you should
probably pick up this patch.

Mikey


In message <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com> you wrote:
> 
> On Feb 19, 2012, at 4:48 PM, Michael Neuling wrote:
> 
> > linux next-20120217 compiling ppc64e_defconfig fails with:
> >=20
> > arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
> > arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of =
> function 'of_detach_node'
> >=20
> > The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> Acked-by: Jimi Xenidis <jimix@pobox.com>
> 
> >=20
> > diff --git a/arch/powerpc/platforms/wsp/Kconfig =
> b/arch/powerpc/platforms/wsp/Kconfig
> > index 57d22a2..79d2225 100644
> > --- a/arch/powerpc/platforms/wsp/Kconfig
> > +++ b/arch/powerpc/platforms/wsp/Kconfig
> > @@ -25,6 +25,7 @@ config PPC_CHROMA
> > 	bool "PowerEN PCIe Chroma Card"
> > 	select EPAPR_BOOT
> > 	select PPC_WSP
> > +	select OF_DYNAMIC
> > 	default y
> >=20
> > endmenu
>